Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 97901

Summary:

[ViewMgmt] [RCP] tab group with non-closeable view can still be moved

Product:

[Eclipse Project] Platform

Reporter:

Boris Bokowski <bokowski>

Component:

Assignee:

Paul Webster <pwebster>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

emoffatt, sxenos, tom.schindl, yharms

Version:

3.1

Keywords:

helpwanted

Target Milestone:

3.4 M2

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Code identified	none

Description Boris Bokowski

2005-06-01 12:00:34 EDT

While you cannot move a non-closeable view, you can still move its tab group.  
This allows the view to be moved, you can drop it on a different tab group or 
detach it.

Comment 1 Boris Bokowski

2005-06-01 12:01:53 EDT

Right-click on the view's tab and select Move->Tab Group to move the tab group.

Comment 2 Boris Bokowski

2005-06-01 13:42:06 EDT

Using this trick you can also put a standalone view into an existing tab group.

Comment 3 Boris Bokowski

2005-06-08 11:02:48 EDT

Using this trick, a user could first detach a non-closeable view and then close
it (see bug 97859).

Comment 4 Paul Webster

2006-09-28 15:15:01 EDT

Is this still a problem in 3.3?

PW

Comment 5 Boris Bokowski

2006-09-28 19:31:56 EDT

I'm pretty sure it is.

Comment 6 Thomas Schindl

2007-08-07 10:51:36 EDT

Paul do you look into this else I'll dive into it and report my findings because in my RCP this is quite annoying. The only work-around currently is to set the layout to fixed.

Comment 7 Thomas Schindl

2007-08-07 11:53:12 EDT

Created attachment 75549 [details]
Code identified

Well I have identified the relevant code part and this fixes the problem but I'm uncertain this is desired because this way a contributed view can make a TabGroup not moveable. Maybe we should introduce at least a configure option for to turn this on or off.

Comment 8 Thomas Schindl

2007-08-07 11:54:30 EDT

Adding Eric because this has to do with presentations

Comment 9 Paul Webster

2007-08-07 12:40:59 EDT

One topic for discussion and a piece of information.

What makes a tabbed stack immovable?  If all of the views are immovable?  If all of the original views in the stack are immovable? (i.e. discounting perspectiveExtensions).

I don't think a single immovable view in a stack should prevent the entire stack from moving, but certainly if all of the views are immovable you shouldn't be able to move the stack either.


Info:  Folders in 3.3 can contain layout properties to pass extra information to the perspective.  Perhaps the folder can be marked as immovable by the perspective creation/extension reading code.

PW

Comment 10 Paul Webster

2007-08-07 12:41:51 EDT

(In reply to comment #9)
> 
> Info:  Folders in 3.3 can contain layout properties to pass extra information
> to the perspective.  Perhaps the folder can be marked as immovable by the

That should be "to the presentation"

PW

Comment 11 Boris Bokowski

2007-08-07 13:31:52 EDT

As long as you can still move individual (regular) views, I would argue that the whole stack should not be moveable once it has at least one non-moveable view.

Comment 12 Paul Webster

2007-09-13 08:35:53 EDT

Released to HEAD >20070913
PW

Comment 13 Paul Webster

2007-09-18 14:15:09 EDT

(In reply to comment #7)
> Created an attachment (id=75549) [details]
> Code identified

Tom could you verify with the latest I build?

PW

Comment 14 Thomas Schindl

2007-09-18 14:25:05 EDT

Not until tomorrow