Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 97367

Summary: Control the ordering of the root files
Product: [Eclipse Project] PDE Reporter: Pascal Rapicault <pascal>
Component: BuildAssignee: pde-build-inbox <pde-build-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jeffmcaffer, n.a.edgar
Version: 3.1   
Target Milestone: 3.1 RC2   
Hardware: PC   
OS: Windows 2000   
Whiteboard:
Bug Depends on:    
Bug Blocks: 97469    
Attachments:
Description Flags
Patch to AssemblyInformation none

Description Pascal Rapicault CLA 2005-05-30 17:24:33 EDT 
RC1. The order in which root files are being copied is not guaranteed, however
there are many scenarios where making this order clear would help.
Comment 1 Nick Edgar CLA 2005-05-31 09:35:00 EDT 
One scenario is having the SDK feature override the config.ini from the platform
feature, in order to refer to an SDK product extension with different preference
overrides for the initial perspective, and perhaps branding differences.
Comment 2 Pascal Rapicault CLA 2005-05-31 09:57:38 EDT 
Created attachment 22038 [details]
Patch to AssemblyInformation
Comment 3 Pascal Rapicault CLA 2005-06-02 11:52:01 EDT 
DJ could you review?
Comment 4 DJ Houghton CLA 2005-06-02 14:02:53 EDT 
We are switching from using a Set to a LinkedList. I see the early return in
#addRootFileProvider. Are there any other places where we might be adding files
to the list? Is it safer to do a #contains check first to ensure the resource
doesn't already exist? What are the consequences if the file is added to the
list twice?
Comment 5 Pascal Rapicault CLA 2005-06-03 15:28:40 EDT 
I don't have a clear memory as to why I don't use contains() in all this part of
the code, but at the time I had some good reasons that I can't remember now.
So I suggest that for now we keep the fix simple, and that we review the usage
of contains() post 3.1.
What do you think?
Comment 6 DJ Houghton CLA 2005-06-03 15:31:13 EDT 
I think that adding #contains is the simple fix because it ensures the entries
aren't in the list twice and we can review taking it out for 3.2. :-)
Comment 7 Pascal Rapicault CLA 2005-06-06 12:04:46 EDT 
Fixed in HEAD with the contains().