| Summary: | Polishing disassembler output | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Philipe Mulet <philippe_mulet> | ||||
| Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | ||||||
| Version: | 3.1 | ||||||
| Target Milestone: | 3.1 RC2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
52 astore [local_5]
should be:
52 astore 5 (if no name)
52 astore 5 [value] (if there is a name)
Created attachment 22001 [details]
Apply on HEAD
Let me know if this is what you expect. Then I will update all the tests that
are comparing a disassembled output.
Looks good to me. Fixed and released in HEAD. All related tests have been updated. Verified for 3.1 RC2 using build N20050607-0010 + JDT/Core HEAD Verified for 3.1 RC2 using build I20050610-0010 |
Build 3.1m7 1. in COMPACT mode, it should compact field access return types and thrown exceptions. public static void main(String[] arg) throws java.lang.Exception; should be: public static void main(String[] arg) throws Exception; 14 getstatic System.out Ljava/io/PrintStream; [36] should be: 14 getstatic System.out : PrintStream; [36] [also note ':' to separate field from return type] 2. on method invocations, the return type should be appended at the end, instead of leading the method name. 7 invokevirtual Object X.create() [30] should be: 7 invokevirtual X.create() : Object [30]