Bugzilla – Full Text Bug Listing
| Summary: | [Import/Export] Import doesn't import empty directories | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Aaron Luchko <aaron> | ||||||||||||
| Component: | UI | Assignee: | Karice McIntyre <Karice_McIntyre> | ||||||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||||||
| Severity: | normal | ||||||||||||||
| Priority: | P3 | CC: | billy.biggs, knut_radloff, pombredanne, pwebster, Tod_Creasey | ||||||||||||
| Version: | 3.1 | ||||||||||||||
| Target Milestone: | 3.2 M4 | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Aaron Luchko
This behavior also occurs with file system imports. As a side note eclipse does allow you to create empty directories so this is a case where a project exported and reimported will not match the original project. This is a dupe of Bug 33171 and Bug 69565. There is a slight issue with the UI and what it allows you to select. I prototyped a fix a few months back and ran into some issues with the UI which is why you don't see any patch available. Okay though those bugs seem slightly different as they're referring only to File System and Archive imports, this bug also refers to Existing Projects. I'll hold off looking at the File System/Archive part of it but do you see any issues with a patch to Import Existing Projets (I think I've found one)? Created attachment 21912 [details]
fix
This patch fixes the functionality in Zip and Tar imports of Existing Project,
the bug didn't exist with Existing Projects from the file system so behavior
among the three is now consistent.
I also removed an extraneous comment from WizardProjectsImportPage.java
This would be a nice fix, but since the problem exists in the other wizards I don't think this is critical for 3.1. The patch seems reasonable though. Should this fix be considered for 3.1.1 and/or 3.2? *** Bug 33171 has been marked as a duplicate of this bug. *** I have tried the patch and it is not working for me. When I do Import Existing Project and select an archive file (that I created using Export>Archive wizard) with a project in it, my project is not showing up in the list. Also, this fix affects the Archive Import wizard as well - when I select that same archive file in the Import>Archive wizard, nothing shows up to select as source in the tree and list viewers . I think the File System Import not importing empty folders will require a separate fix. Created attachment 26870 [details]
fixed patch
Sorry about the bug in the last one, I've fixed the bug and tested a little
more extensively in this one against both 3_1Maintainance and HEAD.
Also it should be noted this patch is meant only to affect importing existing
projects as archive files, as well I don't believe there's a way to create
archive files with empty directories from eclipse currently.
I checked the latest patch (0906) and it works for me. Note this fix only applies for the import existing project, archive option. The same bug still exists for the file system and archive imports (see bug 33171). Tod, can you check this patch? The patch looks fine to me but we still need a test case. If you could attach a tar and a zip with the issue then we could use that for verification. I have released the patch for build > 20051107 I was only able to create a test archive for the zip case. Anyone know how to create a tar file with an empty folder? So far my attempts have not been successful. Created attachment 29613 [details]
put archive in data/org.eclipse.datatransferArchives folder
Test data zip file.
Created attachment 29615 [details]
put archive in data/org.eclipse.datatransferArchives folder
Test data tar file.
Created attachment 29617 [details]
patch for ImportExistingTests.java
Added 2 tests (1 each for tar and zip) to import from archive that has an empty
folder.
Tod, can you check the patch for the added tests? Note: The patch for this bug caused bug 115800. Released the tests from comment #16 into HEAD >20051111 PW Thanks, Paul. Marking fixed since test is released now. Verified in I20051213-0010 |