Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 95534

Summary: [Preferences] Workspace preference page does not show file line delimiter default
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: CLOSED DUPLICATE QA Contact: Oleg Besedin <ob1.eclipse>
Severity: normal    
Priority: P3 CC: markus.kell.r, michaelvanmeekeren, sptaszkiewicz
Version: 3.1Keywords: helpwanted
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Image showing the inconsistencies none

Description Dani Megert CLA 2005-05-17 08:14:04 EDT
The Editors Preference page does not show the file line delimiter default. This
is not consistent with the encoding pref where the default is shown in parenthesis.

In addition the combo is empty while for the encoding it already shows a value
(the default).
Comment 1 Dani Megert CLA 2005-05-17 08:14:43 EDT
Created attachment 21252 [details]
Image showing the inconsistencies
Comment 2 Dani Megert CLA 2005-05-18 16:45:20 EDT
During a ST discussion with MvM the point was made that the default can't be
determined since editors (and other clients) are free to use what they want in
this (default) case. I tend to disagree here (minor exception see last
paragraph): either they decide to use the new preference or not. If they use it
they will get the whatever default we (the workspace preference) provide and
they will also get the custom value if the user changes it. If they do not use
the default (and use what they want) they will most likely also not use the
custom value.

I suggest to use Java's 'line.separator' system property and resolve this to a
display name using Platform.knownPlatformLineSeparators().

Open question: what if this is not one of "r", "n", "rn" but e.g. "foo"? A
Document for example currently defaults to one of "r", "n", "rn" in such a case
without reporting any error. Platform Runtime could add such an uncommon line
delimiter to its list and use also use it as display name.
Comment 3 Tod Creasey CLA 2007-06-14 13:33:47 EDT
This is on the Workspace page now
Comment 4 Markus Keller CLA 2007-06-14 14:35:09 EDT
> This is on the Workspace page now
... but the default is still not visible.
Comment 5 Susan McCourt CLA 2009-07-09 19:27:04 EDT
As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009
Comment 6 Szymon Ptaszkiewicz CLA 2011-09-20 05:30:51 EDT
Dani, we have a patch for that in bug 205731. I will mark this one as duplicate.

*** This bug has been marked as a duplicate of bug 205731 ***