| Summary: | [Preferences] Workspace preference page does not show file line delimiter default | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> | ||||
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Oleg Besedin <ob1.eclipse> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | markus.kell.r, michaelvanmeekeren, sptaszkiewicz | ||||
| Version: | 3.1 | Keywords: | helpwanted | ||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Dani Megert
Created attachment 21252 [details]
Image showing the inconsistencies
During a ST discussion with MvM the point was made that the default can't be determined since editors (and other clients) are free to use what they want in this (default) case. I tend to disagree here (minor exception see last paragraph): either they decide to use the new preference or not. If they use it they will get the whatever default we (the workspace preference) provide and they will also get the custom value if the user changes it. If they do not use the default (and use what they want) they will most likely also not use the custom value. I suggest to use Java's 'line.separator' system property and resolve this to a display name using Platform.knownPlatformLineSeparators(). Open question: what if this is not one of "r", "n", "rn" but e.g. "foo"? A Document for example currently defaults to one of "r", "n", "rn" in such a case without reporting any error. Platform Runtime could add such an uncommon line delimiter to its list and use also use it as display name. This is on the Workspace page now > This is on the Workspace page now
... but the default is still not visible.
Dani, we have a patch for that in bug 205731. I will mark this one as duplicate. *** This bug has been marked as a duplicate of bug 205731 *** |