Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 95353

Summary:

Eclipse folder should have a custom icon

Product:

[Eclipse Project] Platform

Reporter:

Kim Horne <eclipse>

Component:

Releng

Assignee:

Platform-Releng-Inbox <platform-releng-inbox>

Status:

CLOSED WONTFIX

QA Contact:

Severity:

enhancement

Priority:

CC:

akurtakov, andre_weinand, Mike_Wilson, pascal, snorthov

Version:

3.1

Keywords:

helpwanted

Target Milestone:

---

Hardware:

Macintosh

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
The folder icon	none

Description Kim Horne

2005-05-16 09:42:15 EDT

When you unpack eclipse on OS X and drop it in your Application folder (if you're the kind of person that 
does such a thing) it tends to look rather anonymous mixed in with the other applications.  Often, 
programs that are installed in a directory (rather than a .app) have a custom icon associated with their 
folder to distinguish it somehow.  It'd be nice if eclipse could do the same thing. 

Over the weekend I was playing around with this and whipped up a folder icon overlayed with the Eclipse 
icon.  Perhaps we could include this in our releases?

Comment 1 Kim Horne

2005-05-16 09:45:44 EDT

Created attachment 21203 [details]
The folder icon

The icon I came up with.  I chose to omit the eclipse logo at smaller sizes as
it wasn't clear what it represented.

Comment 2 Mike Wilson

2005-05-16 10:08:45 EDT

Seems like a reasonably safe thing to do, which would improve the Mac polish.

Comment 3 Sonia Dimitrov

2005-05-16 12:29:48 EDT

Does the icon go in the root of the eclipse directory?

Comment 4 Kim Horne

2005-05-16 13:27:10 EDT

I'm not entirely sure how this works... I'm investigating how to do this at the moment.

Comment 5 Kim Horne

2005-05-16 14:58:14 EDT

Without actually building the release on a Mac I'm not sure how we can make this happen.  I don't know 
how to go about preserving the resource forks such that our builder would maintain them.  Perhaps there 
is some kind soul in SWT land who might have an idea?

Comment 6 Pascal Rapicault

2005-05-25 22:23:51 EDT

Where would this icon be?
What is the structure on disk of the app with this icon?

Comment 7 Philippe Ombredanne

2005-05-26 00:45:10 EDT

What about making the top level eclipse directory a bundle?
(ie renaming the top eclipse folder to eclipse.framework or eclipse.app)
Bundle folders (like the existing Eclipse.app) can include only resource files
and do not have to be executable. A framework bundle (non opaque by default, ie
broswable content) may be more appropriate.
With its own Info.plist pointing to an icon file and looking something like that:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN"
"http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
  <dict>
	<key>CFBundleGetInfoString</key>
	<string>Eclipse 3.1 for Mac OS X</string>
	<key>NSHumanReadableCopyright</key>
	<string>Copyright IBM Corp. and others 2002, 2004. All rights reserved.</string>
	<key>CFBundleIconFile</key>
	<string>Eclipse.app/Content/Resources/EclipseFolder.icns</string>
	<key>CFBundleIdentifier</key>
	<string>org.eclipse.framework</string>
	<key>CFBundleDisplayName</key>
	<string>eclipse</string>
	<key>CFBundleInfoDictionaryVersion</key>
	<string>6.0</string>
	<key>CFBundlePackageType</key>
	<string>FMWK</string>
	<key>CFBundleShortVersionString</key>
	<string></string>
	<key>CFBundleSignature</key>
	<string>????</string>
	<key>CFBundleVersion</key>
	<string>3.1.0</string>
  </dict>
</plist>

I do not have a mac handy right now, but that should work AFAIK.

Comment 8 Philippe Ombredanne

2005-05-26 00:47:09 EDT

Or set the bundle bit on the folder, (I do not know how to) and do not know if
that would be preserved with a tar.And use a plist.

Comment 9 Pascal Rapicault

2005-05-26 09:47:39 EDT

A discussion on shipping eclipse as a mac bundle is going on in bug #57349.
See the first comment from Andre.

Comment 10 Philippe Ombredanne

2005-05-26 16:09:20 EDT

PaScaL:
the suggestion here would be to have in fact two bundles.
The top directory becomes an non-opaque framework bundle with icons, while the
lower level bundle .app , opaque could stay as it is today. This a kind of
hacky...as there would be bundle within a bundle!

Comment 11 Alexander Kurtakov

2016-12-05 06:52:50 EST

Really outdated bug which I believe has been long fixed. Please reopen if this is still the case.