Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 95297

Summary:

Ant export filter: Export also JUnit tests

Product:

[Eclipse Project] Platform

Reporter:

Richard . <haihappen>

Component:

Ant

Assignee:

Kevin Barnes <cocoakevin>

Status:

VERIFIED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

Darin_Swanson

Version:

3.1

Target Milestone:

3.1 RC1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Fixed source.	none
Fixed source.	none

Description Richard .

2005-05-15 04:59:52 EDT

Currently only the run configuration for applications and applets are exported.
JUnit support only has to be commented in.

Comment 1 Richard .

2005-05-15 05:02:46 EDT

The commented out source is already marked with TODO in: BuildFileCreator.java

Comment 2 Richard .

2005-05-15 05:39:32 EDT

Also comment in again: ExportUtil.findTestsInContainer().

Comment 3 Darin Swanson

2005-05-15 12:56:19 EDT

The problem with the JUnit test support is the reference / use of internal 
classes from another component.

Comment 4 Richard .

2005-05-15 16:53:01 EDT

Created attachment 21186 [details]
Fixed source.

I copied relevant methods from TestSearchEngine to ExportUtil. This avoids the
dependency, but what about the code duplicate?

Comment 5 Richard .

2005-05-15 17:12:33 EDT

Created attachment 21187 [details]
Fixed source.

Comment 6 Darin Swanson

2005-05-15 22:44:45 EDT

Code duplication is not great...we will need to work with the JUnit support 
post 3.1 for them to publish (make API) the parts we are interested in.

Comment 7 Darin Swanson

2005-05-18 14:41:03 EDT

Entered bug 95819 for post 3.1 junit work.

Comment 8 Darin Swanson

2005-05-18 14:42:03 EDT

Thanks for the patches Richard.

Small changes to remove using of Jdt Core internal Region class.

Fixed in 
BuildFileCreator and ExportUtil.

Comment 9 Darin Swanson

2005-05-18 14:42:44 EDT

Please verify Kevin.

Comment 10 Kevin Barnes

2005-05-20 12:32:53 EDT

verified