Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 94918

Summary:	[ltk] inappropriate status message if user vetoes file modification [refactoring]
Product:	[Eclipse Project] JDT	Reporter:	Tobias Widmer <tobias_widmer>
Component:	UI	Assignee:	JDT-UI-Inbox <jdt-ui-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.1
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:	stalebug

Description Tobias Widmer

2005-05-12 05:46:06 EDT

I20050509-2010

Steps to reproduce:
- Checkout project in watch/edit mode, using settings send notifications to 
CVS server and always prompt
- Open a java file containing code with local variables that can be inlined
- Invoke the Inline refactoring on one of the variables
- When prompted to send a notification, choose no

-> Refactoring shows message box "User vetoed file modification"

In order to be able to construct a more meaningful message, the refactoring 
needs a status (or multistatus) containing the names of the files which have 
been passed to IWorkspace#validateEdit

Comment 1 Michael Valenta

2005-05-12 12:07:34 EDT

Actually, in this case (i.e. user cancel), the severity of the returned status 
is IStatus.CANCEL. The refactoring in question should check for this first. In 
cancel cases, it is usual not to show the user any error prompt as they 
explicitly choose to prevent the operation. Moving to JDT UI to consider.

Comment 2 Dirk Baeumer

2006-04-05 11:30:51 EDT

Moving due to ownership changes.

Comment 3 Eclipse Genie

2018-12-27 04:40:10 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.