Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 94778

Summary:	[general] refactorings handle file modification vetos differently [refactoring]
Product:	[Eclipse Project] JDT	Reporter:	Tobias Widmer <tobias_widmer>
Component:	UI	Assignee:	Markus Keller <markus.kell.r>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	dirk_baeumer
Version:	3.1
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:	stalebug

Description Tobias Widmer

2005-05-11 12:30:05 EDT

I20050509

The refactorings
- ConvertAnonymousToNested
- ExtractMethod
- ExtractTemp
- InlineTemp
- PromoteTemp

return an info status for modification vetos, whereas the other refactorings 
return a fatal error status.

Steps to reproduce:
- Check out project in watch/edit mode, using the settings send notifications 
to CVS and always prompt.
- Execute one of the mentioned refactorings
- Choose no when prompted to send notification
- Refactoring shows info status

Comment 1 Tobias Widmer

2005-05-11 12:54:46 EDT

Fixed > 20050511

Comment 2 Dirk Baeumer

2005-05-11 13:43:48 EDT

Tobias, after thinking about it a little bit more doing the validation for
refactoring which only manipulate a single file seems to be a good idea.
Otherwise (for example for extract method) the user provides all the input but
the refactoring can't be applied since the file is read-only. We should
reconsider if the current strategy isn't the best we can do right now.

Comment 3 Martin Aeschlimann

2005-05-12 10:31:00 EDT

change reverted

Comment 4 Tobias Widmer

2005-05-17 05:17:16 EDT

I agree on the current process for single-file refactorings. We should however 
make the status severities consistent.

Comment 5 Dirk Baeumer

2005-05-25 09:34:07 EDT

Deferring post 3.1.

Comment 6 Tobias Widmer

2006-04-27 04:42:21 EDT

Not for 3.2

Comment 7 Eclipse Genie

2020-04-22 15:40:41 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.