Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 94661

Summary:	[general] refactorings show fatal error status in watch/edit mode [refactoring]
Product:	[Eclipse Project] JDT	Reporter:	Tobias Widmer <tobias_widmer>
Component:	UI	Assignee:	JDT-UI-Inbox <jdt-ui-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.1
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:	stalebug

Description Tobias Widmer

2005-05-11 07:33:51 EDT

I20050509-2010:

Steps to reproduce:
- Check out a project in watch/edit mode, using send notification and always 
prompt
- Rename a java element
- Refactoring shows Perform Edit? dialog
- Choose no
-> Refactoring shows fatal error status
-> The refactoring should silently quit, since the user chose not to continue, 
or at least provide a more meaningful and less severe status message

Comment 1 Tobias Widmer

2005-05-11 08:51:16 EDT

Refactorings which show no refactoring wizard like inline temp or rename temp 
show the same status message but with severity info

Comment 2 Dirk Baeumer

2005-05-11 12:40:31 EDT

The problem is that refactoring doesn't know that there was a user action in
between. All refactoring knows is that the result from validateEdit is an error
status and therefore shows the error to the users.

To get the requested behavior (which from a user standpoint is valid) the
returned status has to have some additional information why the file couldn't be
made writable. Then the refactoring could interpret this informaiton and could
quit without a further error dialog in the described case.

Moving to Platform/Resource to consider such an API extension.

Comment 3 Tobias Widmer

2005-05-11 12:58:38 EDT

The refactorings which showed an info status have been adapted (see bug 94778)

Comment 4 John Arthorne

2005-05-18 16:14:45 EDT

You can distinguish these cases as follows: if the user choses not to proceed
with validateEdit, a status of severity CANCEL is returned. If the checkout
fails, an status with severity ERROR is returned. The platform core validateEdit
doc was recently updated to clarify this (bug 67657).  If the CVS validateEdit
doesn't match this behaviour then I suggest logging a bug against CVS (Michael
Valenta claims it obeys this spec).

Comment 5 Dirk Baeumer

2005-05-26 11:13:40 EDT

Annying, but no action planned for 3.1. However we should reconsider this for
3.2 and make it a nicer experience.

Comment 6 Eclipse Genie

2020-02-22 07:14:01 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.