| Summary: | Background color for the setMessage and setErrorMessage of a WizardPage do not match | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Brent Thurgood <bthurgoo> |
| Component: | UI | Assignee: | Billy Biggs <billy.biggs> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 3.1 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
I am going to mark this as a duplicate of bug 91217 since it's related to the same issue, and I think we should continue the discussion there. |
The background color of the setMesage() and setErrorMessage on a WizardPage do not match. The setErrorMessage method of the TitleAreaDialog uses the background of the messageLabel for the non-error case, however it uses the JFaceColors.getErrorBackground() color for the error case. When the setErrorMessage() method is called it causes a gray box to appear within the title area on a white background. It would be preferred to have the background color of the message and error be the same. The error message already contains an error image to notify the user of the problem. Changing the color does not look good. Snippet from TitleAreaDialog.setErrorMessage() if (!showingError) { // we were not previously showing an error showingError = true; // lazy initialize the error background color and image if (errorMsgAreaBackground == null) { errorMsgAreaBackground = JFaceColors .getErrorBackground(messageLabel.getDisplay()); errorMsgImage = JFaceResources .getImage(DLG_IMG_TITLE_ERROR); } // show the error normalMsgAreaBackground = messageLabel.getBackground(); setMessageBackgrounds(true); messageImageLabel.setImage(errorMsgImage); setImageLabelVisible(true); } Within a