Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 93654

Summary:

Provide select all / deselect all buttons for JavaWorkingSetPage

Product:

[Eclipse Project] JDT

Reporter:

Troy Bishop <tjbishop>

Component:

Assignee:

Dirk Baeumer <dirk_baeumer>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

Version:

3.1

Target Milestone:

3.1 RC1

Hardware:

OS:

Windows 2000

Whiteboard:

Attachments:

Description	Flags
JavaWorkingSetPage patch	none
\WorkingSetMessages.java patch	none
WorkingSetMessages.properties patch	none
Updated JavaWorkingSetPage patch to ensure that the buttons size is set correctly.	none

Description Troy Bishop

2005-05-04 10:48:33 EDT

As discussed in bug 46669, a select all and deselect all button would be very
nice to have on the working set editor page.  It seems that each contributor to
the working set type needs to provide the UI for their working set page so I've
created a patch against CVS HEAD for JDT UI to use for the 'Java' working set
type.  Is this something that could be added for the 3.1 release?  Thanks a lot!

Comment 1 Troy Bishop

2005-05-04 10:49:28 EDT

Created attachment 20681 [details]
JavaWorkingSetPage patch

Comment 2 Troy Bishop

2005-05-04 10:49:59 EDT

Created attachment 20682 [details]
\WorkingSetMessages.java patch

Comment 3 Troy Bishop

2005-05-04 10:50:21 EDT

Created attachment 20683 [details]
WorkingSetMessages.properties patch

Comment 4 Troy Bishop

2005-05-05 10:01:34 EDT

Created attachment 20736 [details]
Updated JavaWorkingSetPage patch to ensure that the buttons size is set correctly.

Comment 5 Kim Horne

2005-05-16 10:40:39 EDT

The dialog font should also be set on the buttons.

Comment 6 Troy Bishop

2005-05-17 16:41:04 EDT

Would it be possible for this to be added to 3.1 RC1, or at minimum can I get
confirmation that it will be added for the final 3.1 release?  All of the other
working set dialogs have these buttons applied for RC1 and it would look odd if
the 'Java' working set dialog did not.  Thanks a lot!

Comment 7 Dirk Baeumer

2005-05-17 19:08:47 EDT

Troy, thanks for the patch, I will release it for RC1. However I have to say
that I find it strange that we push for such a minor item so shortly before we
ship 3.1. Is there any underlying reason for this I am not aware of.

Additionally some comments to the patch:

- NLS strings should never be reused accross dialog compenents. I introduced
  new strings for the buttons in the JavaWorkingSetPage namespace

- the margins of the surrounding composite have to be set to zero. Otherwise
  the buttons do not allign well with the check box table.

Comment 8 Dirk Baeumer

2005-05-18 04:03:21 EDT

Fixed.

Comment 9 Troy Bishop

2005-05-24 11:21:37 EDT

Thanks Dirk, it works great.