Bugzilla – Full Text Bug Listing
| Summary: | It should be possible to export cross platform | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Jeff McAffer <jeffmcaffer> | ||||||||
| Component: | UI | Assignee: | PDE-UI-Inbox <pde-ui-inbox> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | alexander.smirnoff, ed.burnette, h1055071, n.a.edgar, pascal | ||||||||
| Version: | 3.1 | ||||||||||
| Target Milestone: | 3.1 M7 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Jeff McAffer
Created attachment 20253 [details]
patch to do cross platform exports
Created attachment 20269 [details]
A newer version of the patch to fix up some root file/branding issues
Created attachment 20389 [details] An even BETTER patch This one requires some changes to PDE build. see bug 92855 *** Bug 88507 has been marked as a duplicate of this bug. *** *** Bug 86799 has been marked as a duplicate of this bug. *** *** Bug 82795 has been marked as a duplicate of this bug. *** For the UI portion of it, I would like to show a checkbox table with a number of valid os-ws-arch combinations and select/deselect All buttons. The page would show up only if the RCP delta pack is installed. The list will contain the following combinations: win32-win32-x86 linux-motif-x86 linux-gtk-x86 linux-gtk-x86_64 solaris-motif-sparc solaris-gtk-sparc aix-motif-ppc mac-carbon-ppc This should be more than enough. No plans/time to allow the user to enter arbitrary combinations - for 3.1. That sounds fine to me. The interface in comment #7 sounds great. As long as it doesn't appear mysteriously empty if the delta pack is not there. There should be an error or something to head off the 'why doesn't this work / did you install the delta pack' type questions from users. the wizard will have a single page (as it looks today) if the delta pack is not installed. I'm a little bummed by the inability to enter my own values. One of the first things i wanted to do when starting RCP apps in earnest was to export for my PocketPC. (win32, wm2003, arm). With the rapid addition of new platforms to the Eclipse line up and people adding ports themselves, it seems like this will be a barrier. Is that you don't have enough time or that you don't see the usecase? Note that I am not closing the door on adding new pre-sets. I could add pre-set target environments easily, including the one you are suggesting. Coming up with an esthetically pleasing UI that, in addition to pre-sets, allows the user to enter arbitrary values will involve a production involving new dialogs, editable combo boxes, etc. The usecase, as valid as it may be, is not common enough to warrant spending valuable M7 time on such a UI. Fair enough. A thought. If the set of presets was in a file somewhere that "in the know" users could edit... sure. Ironically, with JARd plugins, editing such a file might not be as easy as it once was :-) > If the set of presets was in a file somewhere
Sounds like a job for an extension point.
Sure that makes sense time permitting. Done. This is a wonderful feature.
Thanks to Jeff for a great patch. (It's going on my list of 10 best patches
of the year :-)
Here is how it will work:
1. There is no hardcoded list of platform combinations.
In the presence of a delta pack, I navigate the directory structure of the bin
folder of the delta pack feature and construct a list of os-ws-arch
combinations.
So Jeff, you could manually add folders to that feature if the current list of
10 os-ws-arch combinations is not enough.
The wizard will have a second page (visible only with delta pack) that
contains a flat check list of all combinations I find.
In the absence of a delta pack, business as usual, ie. we only export to the
Target Environment as specified in the preferences.
2. The .product file must list all fragments required for the cross-platform
export. I contemplated doing some magic during the export operation to
implicitly append fragments not in the .product file. But that may result in
me picking up unwanted fragments. Plus, it is important for the product file
to be complete so that it would get interpreted the same by all interested
parties.
3. For any os-ws-arch combination export, only fragments/plugins that match
the environment filter will make it into the zip and into the config.ini.
So for a win32-win32-x84 export, all linux/solaris/mac fragments that may be
listed in the product file are ignored.
4. The 'Add Required Plugins' button in the product editor will include all
fragments from the delta pack if it exists.
5. If you choose to export to D:/Temp, the end result would look like:
D:/Temp/win32.win32.x86/myproduct
/linux.gtk.x86/myproduct
/solaris.motif.spar/myproduct
I also added descriptive text on the Overview page of the product editor to tell people what they need to do if they want to do a cross-platform export. But there's still a problem with the automatic copying of startup.jar. I downloaded eclipse-SDK-I20050510-0010-win32 and delta pack. When I do a product export of only win32, the copied startup.jar is the correct one (30.2kb). But when I export for 3 platforms in one go (win32, carbon and linux) the copied across startup.jar is bogus (only 2.97kb). PB I noticed that too. Pascal, has Bugzilla corrupted startup.jar that is in the delta pack feature? I replaced the one in the Delta pack and it works OK. Next problem is that the Mac launcher file is not being seen as an executable... I opened bug 94295 for the startup.jar problem. Philippe, if you have other issues, please open separate bug reports. thanks. |