Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 90726

Summary: TableColumn trim differs between platforms
Product: [Eclipse Project] Platform Reporter: Nick Edgar <n.a.edgar>
Component: Update (deprecated - use Eclipse>Equinox>p2)Assignee: Branko Tripkovic <btripkov>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: birsan
Version: 3.1   
Target Milestone: 3.1   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Nick Edgar CLA 2005-04-07 17:30:52 EDT 
build I20050405

Due to platform-specific differences in trim on table columns, references to
ColumnPixelData, and the TableLayoutComposite implementation, should be fixed up
as per bug 90712.
Comment 1 Dorian Birsan CLA 2005-04-07 19:01:11 EDT 
Nick,is there any problem in update or you just assume there is one?
I don't fully understand what needs to be done, could you explain or provide a 
patch? Thanks!
Comment 2 Nick Edgar CLA 2005-04-08 10:06:50 EDT 
The problem is that, in several places, we're specifying a magic value of 19 for
a table column width, in order to leave enough space for a 16x16 icon.  The
extra 3 pixels is a magic value, that is platform-specific and is not nearly
sufficient on the Mac (it needs 24 extra pixels!)

SWT currently compensates for this by adding a fudge factor to the table column
width, but this causes other problems, and they are removing this, so clients
will need to adapt.

The following case in RevertConfigurationWizardPage looks suspicious:
	tlComposite.addColumnData(new ColumnPixelData(20, true));

I'm not sure how to invoke this wizard.  But if it is showing a 16x16 icon in
the first column, this should change to:
	tlComposite.addColumnData(new ColumnPixelData(16, true, true));

But because you (and JDT) have copied the TableLayout logic into
TableLayoutComposite, you'll also need to apply the equivalent changes in bug
90712 to its layout logic, to honour the new addTrim field in ColumnPixelData.
Comment 3 Nick Edgar CLA 2005-05-10 17:54:02 EDT 
This one should be addressed for 3.1.
Comment 4 Dorian Birsan CLA 2005-05-10 18:41:51 EDT 
yes, Branko or Dejan (the in-house pixel expert) will look at this.
Comment 5 Branko Tripkovic CLA 2005-06-08 17:44:23 EDT 
FIXED