Bugzilla – Full Text Bug Listing
| Summary: | [KeyBindings] preference page: IllegalArgumentException using KeySequenceText delete | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | John Arthorne <john.arthorne> | ||||||||
| Component: | UI | Assignee: | Tim Mok <timothym> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | 3vanhourigan, benno.baumgartner, channingwalton, daniel_megert, duongn, eclipse, eclipse, ENJ, fuse, igraham, iyers, Karice_McIntyre, markus.kell.r, Michael.Valenta, Mike_Wilson, n.a.edgar, pwebster, remy.suen, Tod_Creasey | ||||||||
| Version: | 3.1 | ||||||||||
| Target Milestone: | 3.4 M3 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | 176235 | ||||||||||
| Bug Blocks: | 174135 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
John Arthorne
Created attachment 19349 [details]
Log file
Unfortunately I can't reproduce with these exact steps. I must have done something slightly different, but I can't figure out what... I take it back. On my second attempt, I hit Alt+F4 to exit, and after shutdown the same exception was in my log file. So, it seems to be consistently reproducible. I'm having problems reproducing this problem. I think you're going to have to show it to me. So my steps to reproduce were completely unrelated. To reproduce, type in a key binding in the Key Sequence "Name" field on the keys preference page, highlight the text, and hit the delete key. The actual steps are: 1.) Type one key in a KeySequenceText 2.) Select all of the contents using the mouse 3.) Press Backspace Arg. This code is complicated and makes my brain melt. I'll try to look at this before 3.1. The preference page re-work has been pulled for the 3.1 plan to work on performance. *** Bug 94264 has been marked as a duplicate of this bug. *** *** Bug 94029 has been marked as a duplicate of this bug. *** *** Bug 95020 has been marked as a duplicate of this bug. *** *** Bug 107709 has been marked as a duplicate of this bug. *** *** Bug 110010 has been marked as a duplicate of this bug. *** *** Bug 111280 has been marked as a duplicate of this bug. *** *** Bug 123292 has been marked as a duplicate of this bug. *** *** Bug 123300 has been marked as a duplicate of this bug. *** *** Bug 131898 has been marked as a duplicate of this bug. *** Moving Dougs bugs *** Bug 140869 has been marked as a duplicate of this bug. *** Is this still a problem in 3.3? PW Still reproducible in 3.3 build I20060926 Steps to reproduce are in comment #6. FYI This is happening to me in Eclipse 3.2 M20061122-0800 *** Bug 179095 has been marked as a duplicate of this bug. *** Still happens in new keys preference page:
!ENTRY org.eclipse.ui 4 0 2007-05-02 12:08:18.796
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.IllegalArgumentException: All triggers in a trigger sequence must be an instance of Trigger
at org.eclipse.jface.bindings.TriggerSequence.<init>(TriggerSequence.java:70)
at org.eclipse.jface.bindings.keys.KeySequence.<init>(KeySequence.java:200)
at org.eclipse.jface.bindings.keys.KeySequence.getInstance(KeySequence.java:131)
at org.eclipse.jface.bindings.keys.KeySequenceText$KeyTrapListener.handleEvent(KeySequenceText.java:127)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:938)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:962)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:947)
at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:975)
at org.eclipse.swt.widgets.Text.sendKeyEvent(Text.java:1299)
at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:971)
at org.eclipse.swt.widgets.Widget.wmChar(Widget.java:1285)
at org.eclipse.swt.widgets.Control.WM_CHAR(Control.java:3764)
at org.eclipse.swt.widgets.Text.WM_CHAR(Text.java:2013)
at org.eclipse.swt.widgets.Control.windowProc(Control.java:3664)
at org.eclipse.swt.widgets.Text.windowProc(Text.java:2008)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4342)
at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2259)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3282)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:820)
at org.eclipse.jface.window.Window.open(Window.java:796)
at org.eclipse.ui.internal.OpenPreferencesAction.run(OpenPreferencesAction.java:65)
at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:545)
at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:490)
at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:402)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:938)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3673)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3284)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2365)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2329)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2204)
at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:153)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:497)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:436)
at org.eclipse.equinox.launcher.Main.run(Main.java:1162)
at org.eclipse.equinox.launcher.Main.main(Main.java:1137)
*** Bug 186099 has been marked as a duplicate of this bug. *** *** Bug 138486 has been marked as a duplicate of this bug. *** Created attachment 79669 [details]
fixes the IAE
It's ok to select the binding and press Backspace or Del to remove the selection or to press another key to overwrite.
Created attachment 80275 [details]
prevents possible NPE
Release to HEAD >20071016 Change the way selected text was deleted from the text widget. PW In I20071030-0010 PW *** Bug 220018 has been marked as a duplicate of this bug. *** This caused a regression, see bug 345372. |