Bugzilla – Full Text Bug Listing
| Summary: | [validation] Move core helper from XML validator to validation framework | ||
|---|---|---|---|
| Product: | [WebTools] WTP Common Tools | Reporter: | Lawrence Mandel <lmandel> |
| Component: | wst.validation | Assignee: | Neeraj Agrawal <nagrawal> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | valentinbaciu, vbhadrir |
| Version: | 0.7 | Keywords: | helpwanted |
| Target Milestone: | Future | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
|
Description
Lawrence Mandel
Lawrence, We have already moved the function that is available in the XML helper to WorkbenchContext the only second part of this defect needs to be fixed i.e the JDT dependency needs to moved to a separate extension point so it is available only for java projects infact not sure if this ext point is really needed. Please comment Two comments/questions. 1. As I understand it, the current state of the validation framework still requires all validators to declare their own helper. We had discussed removing the requirement on the client to provide a helper. 2. Is there currently a default helper contained in the validation framework which clients can reuse or does every client need to define and specify their own helper? Vijay, I'm working on verifying defects. Can you provide answers for my previously asked questions? 1. As I understand it, the current state of the validation framework still requires all validators to declare their own helper. We had discussed removing the requirement on the client to provide a helper. A. We will still have the notion of each validator having an optional helper in the future. In the case where the validator does not provide one the default WorkbenchContext implmentation of IValidationContext will be used and passed in. 2. Is there currently a default helper contained in the validation framework which clients can reuse or does every client need to define and specify their own helper? A. Currently the validator ext defn needs to explicity define the helper as always it has been. They are can used the WorkbenchContext class as the default implmentation if they do not want to implement one i.e usually the cases where the validators are interested only in the changed file uri's So the current state is a validator needs to explicitly state the workbench context that is part of the framework. Can you provide the class that should be used as the helper in this case? I'm going to reopen this defect and leave the target as is. The goal of this defect is for the validation framework to have a default helper and not require validators to explicitly define the helper. The fix to create a default workbench context if not defined in the validator ext point under the helper element is released. I tested on RC5 and when I remove the helper declaration for the WSDL validator the validator is no longer available from the validation framework. The validation preference page does not list the WSDL validator. I also see the following in the log: !ENTRY org.eclipse.wst.validation 4 0 2005-12-20 18:08:12.289 !MESSAGE *** ERROR ***: Tue Dec 20 18:08:12 EST 2005 IWAE0021E Cannot locate meta-data for validator org.eclipse.wst.wsdl.ui.internal.validation.Validator. Starting with WTP 3.0 the majority of the effort is focused on the new validation framework. It is very likely that the old framework will be deprecated. We will continue to main it until all adopters migrate to the new framework. As such, I will mark this old defect as wontfix. |