Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 85679

Summary:	[general] inconsistent error handling of no input in refactorings [refactoring]
Product:	[Eclipse Project] JDT	Reporter:	Tobias Widmer <tobias_widmer>
Component:	UI	Assignee:	JDT-UI-Inbox <jdt-ui-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.1
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:	stalebug

Description Tobias Widmer

2005-02-17 06:44:34 EST

I20050217-0010

Currently, the situation where a refactoring has not received any input from 
the user is handled inconsistently:

Rename refactorings:
Wrong new name gives IStatus.ERROR + disabled next button
No new name gives IStatus.OK + disabled next button

Extract Method:
No name & wrong name both give IStatus.ERROR + disabled next button

Change Method Signature:
Gives initial IStatus.INFO + disabled next button
Adding parameter and then removing it gives IStatus.ERROR + disabled next 
button

Use Supertype:
Gives initial IStatus.INFO + initial selection + enabled next button

Suggestions:
Make behavior similar in all refactorings:
- No initial IStatus.INFO
- Provide initial value/selection if possible in order to enable next button
- Only issue IStatus.ERROR if user input is wrong, and not if the refactoring 
would not change any code (simply disable next button in this case)

Filing individual PR's if we agree on this

Comment 1 Martin Aeschlimann

2005-02-17 10:29:17 EST

Dirk, comments?

Comment 2 Dirk Baeumer

2005-05-26 10:41:59 EDT

No action planned for 3.1.

Comment 3 Dirk Baeumer

2006-04-05 11:11:29 EDT

Moving due to ownership changes.

Comment 4 Eclipse Genie

2020-01-17 05:24:17 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.