Bugzilla – Full Text Bug Listing
| Summary: | [RCP] [PerspectiveBar] New API or pref to set default perspective bar size | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Chris Gross <schtoo> | ||||
| Component: | UI | Assignee: | Eric Moffatt <emoffatt> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | arnaud.chassagne, bojan.milenkoski, bokowski, craighewetson, daniel.kruegler, dyn, ekke, gunnar, ljpm27, michaelvanmeekeren, n.a.edgar, patrick, spacehorst, urs.frei | ||||
| Version: | 3.1 | Keywords: | api, helpwanted | ||||
| Target Milestone: | 3.5 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Chris Gross
Michael, do you have any thoughts here? Either to have it size automatically to the number of items, or have a (hidden) pref setting for the number of visible items (assuming that can be predicted). I like the idea of specifying the number of items to show and have it size to that automatically. The default would be 1 item. However, the option is only really meaningful when the perspective switcher is on the top right. I'd like to see this too. My application has 2 perspectives and it would be nice to show them both on the toolbar. I would like the ability to specify a default set of perspectives that would display in the toolbar. I'm thinking of something like getInitialWindowPerspectiveId, but that returns an array of perspective ids. Maybe something like getInitialToolbarPerspectiveIds? See bug 84226 for preloading the perspective bar (separate from sizing). Will this bug also cover perspectives with larger icons? I'm interested in using stylish PNGs with a size of 64x64 pixels for a demo app. Once we have the Perspective Switcher 'dumbed down' to work like other trim widgets (i.e. it should simply calculate and return its desired size) then the calculation of what size the right side of the CBanner is should be straightforward. I'm not sure if we can do exactly what's here with adding API (not gonna happen since the API freeze was M5) but at least we should be able to default the size on an initial (clean) startup (after that the actual position of the CBanner's 'splitter' is stored in the workspace data anyway. I think that any api changes will have to happen post 3.2... I think a correct default sizing that also takes larger images into account is suitable. The API for sizing it manually can be added post 3.2. Has this functionality been added to 3.3? I've requested the status of this bug in a similar thread: bug 86771 The mechanism that is invoked on the memento should be opened to clients to initially set the width and / or the perspectives to apear on the bar. Would you be able to contribute a patch? See http://wiki.eclipse.org/Platform_UI/How_to_Contribute Created attachment 101202 [details]
Patch proposal for setting the default size via plugin_customization.ini
Patch proposal for setting the default size via plugin_customization.ini using the preference key org.eclipse.ui/PERSPECTIVE_BAR_SIZE = value
I think that this will have to wait until 3.5 since it's an API change... Committed in >20080925. Applied the patch as is. Note that the patch logic won't allow a specific size < MIN_DEFAULT_WIDTH but since it's 45 I don't think its an issue... Marking as FIXED, Mark can you test this when M2 comes out and let me know if it's working as advertised? Verified using the debugger in I20080915-1800. Mark, feel free to post your results to ensure that this is solving your problem. Added attributions...thanks Mark! |