Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 84472

Summary: Type Filters pref page moved under Appearance category [preferences]
Product: [Eclipse Project] JDT Reporter: Randy Hudson <hudsonr>
Component: UIAssignee: Martin Aeschlimann <martinae>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: dirk_baeumer, eclipse
Version: 3.1   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Randy Hudson CLA 2005-02-04 15:16:06 EST
Type filters affect many aspects of JDT, not just appearance.  It's actually 
stuff you don't want to appear anywhere.
This preference page should stay in its 3.0 location under Java. Why isn't 
Debug step-filters under appearance, or "Code Style", or "Hovers", or Syntax 
Coloring? Almost every Java preference page affects the appearance of the UI 
somehow.
Comment 1 Dirk Baeumer CLA 2005-02-07 06:31:40 EST
Martin, can you comment on the rational behind this move.
Comment 2 Martin Aeschlimann CLA 2005-02-07 07:09:12 EST
All the 'type filter' feature does is to filter certain types from the UI. It
does not e.g. hide these types from the compiler.
Appearance settings contain settings to all or several Java views and features.
I think type filters are at the right place there.

Code style is not appearance but how code manipulation tooling should make
modification.
We goups editor settings together, so there's again an appearance settings page
just for editors.
Comment 3 Randy Hudson CLA 2005-02-07 10:44:31 EST
Type filters affect content assist proposals as well, which is like compilation 
in a way. Anyway, every preference is related to the UI and therefore 
appearance, so I won't deny that. The reorg does not provide any benefit to the 
user and has a negative affect on the existing user base which used to know 
where to find this preference page.
Comment 4 Martin Aeschlimann CLA 2005-02-08 04:16:40 EST
Type filters it isn't important enough to have it top level. What other category
would match it better? Code style settings are all per default, appearance
settings per workspace. 
Maybe in the Java Editor section? As a code assist sub-item?

Rady, please let us reopen bugs, just add more comments if you don't agree with
our comments.
Comment 5 Randy Hudson CLA 2005-02-08 11:20:59 EST
> Type filters it isn't important enough to have it top level

I sort of agree, but you've already shipped the product with it there. IMO, you 
need to make a substantial improvement when you go messing with what the user 
has taken the time to learn. Or, if so many other things are changing then you 
can just slip it in.
Comment 6 Martin Aeschlimann CLA 2005-02-14 14:53:06 EST
no action here. What we will do is add a link from the editor -> code assist page