Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 83496

Summary:	[Presentations] Close button doesn't appear in time
Product:	[Eclipse Project] Platform	Reporter:	Gary Feldman <g1list_1a>
Component:	UI	Assignee:	Gunnar Wagenknecht <gunnar>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	ed.burnette, gunnar, veronika_irvine
Version:	3.0.1	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Gary Feldman

2005-01-22 23:57:13 EST

I just installed Eclipse 3.0.1, build 200409161125, and came across this
problem.    I happened to be working with a set of Python files, using
TruStudio, but I don't think that really matters.

Here's the way to reproduce this:  Open up a number of files, at least four or
five, making sure that the names are of similar length, and that the last opened
one is the selected one.  Hover the mouse over the close button on one of the
earlier editor windows (but not the next-to-last one), and click the close
button without moving the mouse.  If the filenames are the right length, the
mouse pointer will be over the location where the close button should appear in
the next tab.  If you click it again, being careful not to move the mouse, the
next window will close - even though the close button didn't appear until after
clicking.

While this may seem like a contrived circumstance, it really isn't for people
using laptops, since it's easy (and for me, common) to click on mouse buttons
without moving the pointer.

Gary  

PS:  While I consider this to be a real bug - the close shouldn't happen unless
the button is visible - I also think it's the result of a poor design decision.
 It's just way too easy to move the mouse over a tab and click, in order to
select that tab, without noticing the close button appear, so you wind up
closing it by accident.  This violates a basic usability rule that destructive
actions shouldn't be easy to perform accidentally.  Close buttons shouldn't be
playing hide and seek.

Gary

Comment 1 Michael Van Meekeren

2005-08-31 14:01:39 EDT

does anyone have time to investigate the code and provide a patch, the code is in:

Project: org.eclipse.ui.presentations.r21
class: org.eclipse.ui.internal.presentations.r21.widgets.CTabFolder

Comment 2 Gunnar Wagenknecht

2005-09-01 01:40:14 EDT

I'm investigating. Unfortunately, I can't "accept" bugs. Thus, please assign to me.

Comment 3 Gunnar Wagenknecht

2005-09-01 02:02:31 EDT

I can't reproduce this wit I20050830-0800. Thus, I suggest closing as WORKSFORME.

Behavior of I20050830-0800:
- fresh workspace
- switch to r21pres and restart
- create a project
- create several files (test1.txt till test9.txt)
- open all in editor
- activate rightmost editor
- move mouse to leftmost editor, till the close button appears (is hovered)
- lift mouse to avoid moving the pointer
- press mouse button while keeping mouse lifted
-> leftmost editor is closed, all tabs shifted to the left
-> mouse is still over close button area, but button is not visible
- press mouse button again (mouse still lifted)
-> leftmost editor is activated and not closed
-> mouse button is still over close area but now close button becomse visible
- press mouse button again (mouse still lifted)
-> editor is closed (expected behavior, because close button was visible and
clicked)

However, I noticed that the 3.0 presentation shows the problematic behavior.

Comment 4 Gunnar Wagenknecht

2005-09-01 02:04:02 EDT

(In reply to comment #3)
> I can't reproduce this wit I20050830-0800. 
> Thus, I suggest closing as WORKSFORME.

Please ignore this because of:

> [...] 3.0 presentation shows the problematic behavior.

Comment 5 Gary Feldman

2005-09-01 08:52:35 EDT

I'll try a recent build to see if it's fixed for me, but it may take me a few
days to get around to it.

Comment 6 Michael Van Meekeren

2005-09-01 09:31:16 EDT

Reassigning to Gunnar (even though this my just be closed as WORKSFORME).

I've also created bug 108567, to capture the 3.0 issue noted "However, I noticed
that the 3.0 presentation shows the problematic behavior."

Comment 7 Gunnar Wagenknecht

2005-09-01 13:09:46 EDT

OK, closing as WORKSFORME.
The 3.0 close behavior is covered in bug 108567.

Comment 8 Gunnar Wagenknecht

2005-09-01 13:10:15 EDT

uhh, wrong resolution

Comment 9 Gunnar Wagenknecht

2005-09-01 13:11:04 EDT

tested with r21pres and I20050830-0800