Bugzilla – Full Text Bug Listing
| Summary: | [HiDPI][Program] Losing icons for External programs at higher OS zoom level | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Tod Creasey <Tod_Creasey> | ||||
| Component: | SWT | Assignee: | Niraj Modi <niraj.modi> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | grant_gayed, kevin, loskutov, lshanmug, markus.kell.r, mistria, niraj.modi, sptaszkiewicz, sravankumarl | ||||
| Version: | 2.0 | ||||||
| Target Milestone: | 4.7 M7 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows All | ||||||
| See Also: |
https://git.eclipse.org/r/96421 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=fd3aa12a5686e7535f4ec79d07a300e654c351bd |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 495269, 516390 | ||||||
| Attachments: |
|
||||||
|
Description
Tod Creasey
Not required to satisfy section 508. Defer. Reopen to investigate Moving to SWT for comment. The icons for the external program are from the API in Program. Sorry, Sridhar. That was a bogus assignment. Should have been SN. This isn't just an accessibility issue - we lose them at regular fonts too. Is currently working on XP Verified that it still fails on 2000. *** Bug 146951 has been marked as a duplicate of this bug. *** Grant, we've changed Program quite a bit over the years, does this still fail in Windows 2000? yes it still happens, a generic image is shown for all of the file types This issue is still occurring, reproduced in latest Kepler download, and latest Mars download, seeing it happen on every windows OS we have tested it on, specifically windows 7, 8, and 10 Reproducible in 4.5.2 and current master. To reproduce on Windows 7, step 1 from comment 0 needs to be performed on the Control Panel > Display page. The other steps are still accurate. Note that nowadays some PCs may have default value higher than 100% which would cause the problem for Eclipse users right from the beginning. This article mentions 125% as the new default: http://nvidia.custhelp.com/app/answers/detail/a_id/3153/~/adjusting-windows-display-size%2Fscaling-for-high-dpi%2Fppi-monitors Markus, this is the bug I mentioned on the status call last week. Created attachment 264528 [details]
screenshot of the dialog on windows 10, 150% zoom
Still same on 4.6.1 & 4.7.0 head. I'm on Windows 10, 150% zoom, but in Eclipse it should use 100% scale factor - still no icons.
(In reply to Andrey Loskutov from comment #15) > Created attachment 264528 [details] > screenshot of the dialog on windows 10, 150% zoom > > Still same on 4.6.1 & 4.7.0 head. I'm on Windows 10, 150% zoom, but in > Eclipse it should use 100% scale factor - still no icons. Yes, this problem still exits on Windows OS zoom level greater than 100%. With my initial investigation, I can see Program#getImageData() correctly returns the associated image at 100% zoom and but when OS zoom value is greater than 100% it's unable to find an associated program image and that may be the reason some default ICON is shown for all Programs in the list. One solution I can think of, is to return the same ICON image(i.e. at 100% zoom) even for higher OS zoom level and auto-Scaled version of the 100% ICON images can be shown again the Program in the list. I am trying this approach. New Gerrit change created: https://git.eclipse.org/r/96421 Gerrit change https://git.eclipse.org/r/96421 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=fd3aa12a5686e7535f4ec79d07a300e654c351bd (In reply to Eclipse Genie from comment #18) > Gerrit change https://git.eclipse.org/r/96421 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=fd3aa12a5686e7535f4ec79d07a300e654c351bd > Above patch works as expected and now we can an auto-Scaled version of the 100% ICON images is shown at higher OS zoom levels. Created bug 516390 to investigate and improve the icons quality for External programs at higher OS zoom levels, resolving this bug now. Verified fix on Win7 at 200% zoom using Build id: I20170508-2000 |