| Summary: | [Import/Export] Multiple Projetcs Import Panel must give information about the projects | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Gabriele Garuglieri <gabriele.garuglieri> |
| Component: | IDE | Assignee: | Platform UI Triaged <platform-ui-triaged> |
| Status: | RESOLVED FIXED | QA Contact: | Prakash Rangaraj <prakash> |
| Severity: | enhancement | ||
| Priority: | P5 | CC: | dev, remy.suen |
| Version: | 3.1 | Keywords: | helpwanted |
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | ip | ||
| Attachments: | |||
|
Description
Gabriele Garuglieri
I think this is closely related to Bug 40493. Any chance they can be addressed within 3.2 timeframe? Thanks, Gabriele This bug is opened since almost 2 (two) years and Bug 40493 is opened since more than 4 (four) years, we are at version 3.4 and still eclipse lacks support for multiple branches projects. To import them we are still forced to edit .project files by hand. What else to say... Please feel free to attach a patch should you have a suggested fix (In reply to comment #0) > The Multiple Projetcs Import Panel must give information about the projects it > is going to import, like the directory it is importing from. How would you expect the user interface to render this information? With two table columns? Something else? Created attachment 85282 [details]
New user interface showing the parent container.
Will something like this suit your needs?
(In reply to comment #5) > Created an attachment (id=85282) [details] > New user interface showing the parent container. > > Will something like this suit your needs? > Yes, great! Until Bug 40493 is solved this at least will allow me to understand what and from where i'm going to import. My best Christmas wishes to everybody. Gabriele Created attachment 85303 [details]
Patch to implement the requested feature.
Created attachment 85313 [details]
New patch that has proper unit tests for the directory case.
I slipped up on the original patch's unit test. This one is accurate. However, it also puts this patch over 250 line mark.
Created attachment 87261 [details]
Screenshot with the patch applied on Vista
I am not quite sure what you are showing here Remy - if the the columns were resizable and the new column took the extra space we could see more of what you are showing.
Created attachment 87263 [details] Corrected patch to show column headers. (In reply to comment #9) > I am not quite sure what you are showing here Remy - if the the columns were > resizable and the new column took the extra space we could see more of what you > are showing. It seems that in my fervent attempt to cut down on the line numbers of this patch (which ultimately failed anyway), I removed a method call to setHeadersVisible(boolean). On GTK+ it seems to be taking up the extra space automatically, I guess this isn't the case on Windows? Created attachment 90579 [details]
Revised patch against HEAD.
The columns can be resized and the text seems to be readable on Vista.
Gabriele, the import wizard has changed a bit in 3.4. Does it suit your needs now? Checked right now. Yes it does, many many thanks. At least now i can see what i'm going to import. As far as i'm concerned this solves my problem so the bug can be closed. Let me know if i should do it myself. (In reply to comment #13) > As far as i'm concerned this solves my problem so the bug can be closed. > Let me know if i should do it myself. Marking it as fixed |