Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 81895

Summary: [Import/Export] Multiple Projetcs Import Panel must give information about the projects
Product: [Eclipse Project] Platform Reporter: Gabriele Garuglieri <gabriele.garuglieri>
Component: IDEAssignee: Platform UI Triaged <platform-ui-triaged>
Status: RESOLVED FIXED QA Contact: Prakash Rangaraj <prakash>
Severity: enhancement    
Priority: P5 CC: dev, remy.suen
Version: 3.1Keywords: helpwanted
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: ip
Attachments:
Description Flags
New user interface showing the parent container.
none
Patch to implement the requested feature.
none
New patch that has proper unit tests for the directory case.
none
Screenshot with the patch applied on Vista
none
Corrected patch to show column headers.
none
Revised patch against HEAD. none

Description Gabriele Garuglieri CLA 2004-12-24 06:30:21 EST
Version: 3.1.0
Build id: 200412162000

The Multiple Projetcs Import Panel must give information about the projects it
is going to import, like the directory it is importing from.
If you have multiple extractions of the same project (for example different CVS
branches) the panel blindly reports multiple times the same project name without
giving any hints about which instance it is.
Comment 1 Gabriele Garuglieri CLA 2006-02-21 03:20:43 EST
I think this is closely related to Bug 40493.
Any chance they can be addressed within 3.2 timeframe?

Thanks, Gabriele
Comment 2 Gabriele Garuglieri CLA 2007-12-14 03:05:25 EST
This bug is opened since almost 2 (two) years and Bug 40493 is opened since more than 4 (four) years, we are at version 3.4 and still eclipse lacks support for multiple branches projects.
To import them we are still forced to edit .project files by hand.

What else to say...
Comment 3 Tod Creasey CLA 2007-12-14 08:00:33 EST
Please feel free to attach a patch should you have a suggested fix
Comment 4 Remy Suen CLA 2007-12-14 09:45:11 EST
(In reply to comment #0)
> The Multiple Projetcs Import Panel must give information about the projects it
> is going to import, like the directory it is importing from.

How would you expect the user interface to render this information? With two table columns? Something else?
Comment 5 Remy Suen CLA 2007-12-14 10:22:11 EST
Created attachment 85282 [details]
New user interface showing the parent container.

Will something like this suit your needs?
Comment 6 Gabriele Garuglieri CLA 2007-12-14 11:48:30 EST
(In reply to comment #5)
> Created an attachment (id=85282) [details]
> New user interface showing the parent container.
> 
> Will something like this suit your needs?
> 
Yes, great!
Until Bug 40493 is solved this at least will allow me to understand what and from where i'm going to import.

My best Christmas wishes to everybody.

Gabriele
Comment 7 Remy Suen CLA 2007-12-14 14:16:35 EST
Created attachment 85303 [details]
Patch to implement the requested feature.
Comment 8 Remy Suen CLA 2007-12-14 18:50:27 EST
Created attachment 85313 [details]
New patch that has proper unit tests for the directory case.

I slipped up on the original patch's unit test. This one is accurate. However, it also puts this patch over 250 line mark.
Comment 9 Tod Creasey CLA 2008-01-18 09:41:27 EST
Created attachment 87261 [details]
Screenshot with the patch applied on Vista

I am not quite sure what you are showing here Remy - if the the columns were resizable and the new column took the extra space we could see more of what you are showing.
Comment 10 Remy Suen CLA 2008-01-18 09:53:32 EST
Created attachment 87263 [details]
Corrected patch to show column headers.

(In reply to comment #9)
> I am not quite sure what you are showing here Remy - if the the columns were
> resizable and the new column took the extra space we could see more of what you
> are showing.

It seems that in my fervent attempt to cut down on the line numbers of this patch (which ultimately failed anyway), I removed a method call to setHeadersVisible(boolean). On GTK+ it seems to be taking up the extra space automatically, I guess this isn't the case on Windows?
Comment 11 Remy Suen CLA 2008-02-24 10:50:07 EST
Created attachment 90579 [details]
Revised patch against HEAD.

The columns can be resized and the text seems to be readable on Vista.
Comment 12 Remy Suen CLA 2008-10-09 08:15:43 EDT
Gabriele, the import wizard has changed a bit in 3.4. Does it suit your needs now?
Comment 13 Gabriele Garuglieri CLA 2008-10-10 02:19:24 EDT
Checked right now. Yes it does, many many thanks.
At least now i can see what i'm going to import.

As far as i'm concerned this solves my problem so the bug can be closed.
Let me know if i should do it myself.

Comment 14 Susan McCourt CLA 2009-07-15 12:11:19 EDT
"As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009"
Comment 15 Prakash Rangaraj CLA 2009-07-16 05:36:46 EDT
(In reply to comment #13)
> As far as i'm concerned this solves my problem so the bug can be closed.
> Let me know if i should do it myself.

Marking it as fixed