Bugzilla – Full Text Bug Listing
| Summary: | [Import/Export] ImportOperation should not have special case for TarFileStructureProvider | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Nick Edgar <n.a.edgar> |
| Component: | IDE | Assignee: | Platform UI Triaged <platform-ui-triaged> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 | CC: | billy.biggs |
| Version: | 3.0 | Keywords: | api, helpwanted |
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 2000 | ||
| Whiteboard: | stalebug | ||
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |
build I20041221 ImportOperation.importFile has: if (provider instanceof TarFileStructureProvider) { try { targetResource.setResourceAttributes(((TarFileStructureProvider) provider).getResourceAttributes(fileObject)); } catch (CoreException e) { errorTable.add(e.getStatus()); } } It's not good form to have the API class ImportOperation, which is trying to be a generic operation, include special-case code for a particular kind of IImportStructureProvider. It would be better to define an API interface IImportStructureProviderWithAttributes that has the getResourceAttributes(Object element), then have TarFileStructuredProvider implement it. This will also allow any new importers that come along to also provide attributes.