Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 81289

Summary:

[Preferences] Preferences dialog header colour not well contrasted

Product:

[Eclipse Project] Platform

Reporter:

Billy Biggs <billy.biggs>

Component:

Assignee:

Tod Creasey <Tod_Creasey>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

michaelvanmeekeren

Version:

3.1

Target Milestone:

3.1 M5

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

80180

Bug Blocks:

Attachments:

Description	Flags
Screenshot	none
screenshot of preference dialog on Windows XP	none
patch to workbench for better margins etc...	none
patch to jface for better margins etc...	none

Description Billy Biggs

2004-12-15 14:27:18 EST

I200412142000

The header of the CTabFolder for the preferences dialog seems to use the selection
colour, which does not contrast well on top of the default widget background.
Screenshot attached.

Comparing with Linux, the contrast there is better, but the colour still seems out
of place.

Comment 1 Billy Biggs

2004-12-15 14:29:14 EST

Created attachment 16661 [details]
Screenshot

Comment 2 Veronika Irvine

2004-12-17 09:38:10 EST

Created attachment 16723 [details]
screenshot of preference dialog on Windows XP

The header also is quite hard to read on Windows XP with the Silver theme

Comment 3 Michael Van Meekeren

2004-12-17 10:07:19 EST

Created attachment 16727 [details]
patch to workbench for better margins etc...

Comment 4 Michael Van Meekeren

2004-12-17 10:08:17 EST

Created attachment 16729 [details]
patch to jface for better margins etc...

Comment 5 Tod Creasey

2004-12-17 10:19:17 EST

Patch from MVM looks great.

Comment 6 Tod Creasey

2005-01-04 11:30:13 EST

Michaels released changes take care of this

Comment 7 Michael Van Meekeren

2005-01-04 11:50:14 EST

adding a dependancy on bug 80180 , as the toolbar background still needs to work
on the MAC for the case where the toolbar is used along the top and contains the
categories view of the preferences.

Comment 8 Tod Creasey

2005-02-16 15:09:20 EST

Verified in 20050215-2300