Bugzilla – Full Text Bug Listing
| Summary: | Ability to add property information to items in the method statistics view. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Ashish Patel <ashishp> | ||||||||
| Component: | TPTP | Assignee: | Eugene Chan <ewchan> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P1 | CC: | analexee, celek, curtispd, dskeen, ewchan, jkubasta, martin.boag, mmings, paulslau, who | ||||||||
| Version: | unspecified | Keywords: | plan | ||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| URL: | http://www.eclipse.org/tptp/groups/Architecture/documents/features/hf_80440.html | ||||||||||
| Whiteboard: | closed460 | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 146268, 166692 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Ashish Patel
I would like to recommend that this method context data should not be appended to the method name. The Hyades trace model group have been working to add support for typed and summarized context string representation of method parameters and return data. Please refer to section "2.3 Method call parameter and return data reporting" in the document at http://dev.eclipse.org/viewcvs/indextools.cgi/~checkout~/hyades- home/docs/components/data_models/trace_model/html/Hyades%20Trace%20Model% 20Requirements%20and%20Solutions.htm#_Toc85538422 This feature has been fully implemented in Hyades 3.2 i1 under bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=74475. However there is already an initial implementation in Hyades 3.01 as noted in the requirements document that will be sufficient for storing a SQL statement string with a method as we have here. The missing part that will limit products based on Hyades 3.0.1 / 3.0.2 is that no view support for this model extension has yet been implemented. I agree with Ashish that this method parameter / return data should be accessible via the tool tips on all trace model viewers. Further notes: It would be ideal that this property support also be present in the UML2 sequence diagram (as per my example in the feature report - if they see a method "executeQuery()" on the UML diagram the user can hover over it and press F2 to see the property information). Raise feature to P2 per Eric Labadie's request. Deferring from 4.1 as per the official 4.1 enhancement plan. http://eclipse.org/tptp/home/project_info/featureplans/features.php?source=All&project=All&release=4.1&file=TPTPFeatures_4.1.xml Deferring from 4.1 as per the official 4.1 enhancement plan. http://eclipse.org/tptp/home/project_info/featureplans/features.php?source=All&project=All&release=4.1&file=TPTPFeatures_4.1.xml Deferring from 4.1 as per the official 4.1 enhancement plan. http://eclipse.org/tptp/home/project_info/featureplans/features.php?source=All&project=All&release=4.1&file=TPTPFeatures_4.1.xml Setting to next release. Setting target to future so it doesn't show up in 4.2 feature query. I am also interested in such an enhancement. It seems commercial products like IBM one use the transaction property... If there is a good reason one should use transaction name instead let me know :) If you can point us to where we need to change the code, let us know too :) Eugene, did we ever size the work required to implement this? Created attachment 81198 [details]
FDD
Approved by the AG for TPTP 4.5 with the following comments: -What hover content will the extender be able to display? Is there a predefined structure to the content? -Will TPTP implement this extension point? -What the organization of the extension point? -Is the hover help going to be a formatted dialog/popup or flyover? -The design, test, and documentation sizings appear low given a new extension point and UI changes. -What is required under the build and infrastructure sizing? Created attachment 91802 [details]
patch
I have created an extension point that adopter can contribute with extending on an abstract class.
extension point example
<extension
point="org.eclipse.tptp.platform.common.ui.TableCellLabelProviders">
<tableCellLabelProvider
class="org.eclipse.tptp.platform.samples.tablecelllabelprovider.TableCellLabelProvider"
id="org.eclipse.tptp.platform.samples.tablecelllabelprovider.TableCellLabelProvider"
name="SampleTableCellLabelProvider">
</tableCellLabelProvider>
</extension>
where class org.eclipse.tptp.platform.samples.tablecelllabelprovider.TableCellLabelProvider extends
public abstract class TableCellLabelProvider {
/**
* Given a cell element and column ID of a table in table viewer, return a
* custom hover text string content for the table cell.
*
* @param element element of row selection in table
* @param columnID column ID as listed in <code>IContextAttributes</code>.
* @return hover text string content
*/
public abstract String getColumnHoverText(Object element,String columnID);
/**
* Return an array of column ID supported by this provider.
*
* @return String array of support column ID as listed in <code>IContextAttributes</code>.
*/
public abstract String[] getSupportColumnKeys();
}
Statistic table viewers are updated to adopt the new provider.
Return string of getColumnHoverText in the provider will be displayed in the hover text dialog whenever user hover its pointer in a table cell that is supported by the provider. If there are multiple providers for a single column, their contributions will be append together with newline between them.
Patch submitted to HEAD. I am working on an example in org.eclipse.tptp.platform.examples.isv to demo how to use the new extension point. Created attachment 92059 [details]
patch of sample
Example project for extension point is checked into HEAD. Patch attached.
Documentation for sample is added: /org.eclipse.tptp.platform.doc.isv/samples/scell_label_extension.html (new) /org.eclipse.tptp.platform.doc.isv/platformisv_toc.xml (modified) /org.eclipse.tptp.platform.examples.isv/plugin.xml (modified) Feature completed. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |