Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 79209

Summary: [PropertiesView] GEF implementation of PropertySheetEntry doesn't apply property changes for editors of type CheckboxCellEditor
Product: [Tools] GEF Reporter: David Green <greensopinion>
Component: GEF-Legacy GEF (MVC)Assignee: Nick Edgar <n.a.edgar>
Status: RESOLVED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: hudsonr
Version: 3.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description David Green CLA 2004-11-22 11:58:28 EST 
org.eclipse.gef.internal.ui.properties.PropertySheetEntry doesn't apply property
changes for org.eclipse.jface.viewers.CheckboxCellEditor, since the
CheckboxCellEditor doesn't have a Control, and
PropertySheetEntry.applyEditorValue() returns at line 120 if the editor's
control is null.

This behaviour is not consistent with
org.eclipse.ui.views.properties.PropertySheetEntry, which appears to work
properly with CheckboxCellEditor.
Comment 1 David Green CLA 2004-11-22 12:27:33 EST 
Defect found in 3.1M3
Comment 2 Nick Edgar CLA 2005-03-22 12:15:36 EST 
Randy, why was this moved to Platform-UI?  David seems to be describing a
problem in GEF's implementation of PropertySheetEntry.
Comment 3 David Green CLA 2005-03-22 12:17:00 EST 
correct, this is a GEF-specific issue.
Comment 4 Randy Hudson CLA 2005-03-22 13:08:14 EST 
He is referring to our copy of the jface class.  JFace has the same bug.  
Anyway, we will subclassing the jface class soon so our copy of the bug is 
irrelevant.
Comment 5 Nick Edgar CLA 2005-03-22 14:17:14 EST 
Please clarify, I'm not seeing the problem.
Comment 6 Nick Edgar CLA 2005-03-22 14:17:58 EST 
From the opening comment:
"org.eclipse.ui.views.properties.PropertySheetEntry ... appears to work
properly with CheckboxCellEditor."
Comment 7 Nick Edgar CLA 2005-03-22 14:18:41 EST 
Also, what do you mean by "the jface class"?  The properties view is in
org.eclipse.ui.views, not JFace.
Comment 8 David Green CLA 2005-03-22 14:45:56 EST 
To be clear: org.eclipse.ui.views.properties.PropertySheetEntry functions
correctly, whereas org.eclipse.gef.internal.ui.properties.PropertySheetEntry
does not.  This is a GEF-specific defect that only occurs when a GEF selection
is made and the property sheet is thusly populated with GEF-based
PropertySheetEntry instances.
Comment 9 Randy Hudson CLA 2005-03-22 15:08:09 EST 
My mistake, I suppose our copy is way out of sync with the one in 
eclipse.ui.views. It looks like we were doing a check to avoid multiple 
applications of the same value.  This would go unnoticed in the platform, but 
in GEF causes two redundant commands to be executed.

So, the class that actually has the bug is being deleted soon. This means if we 
were working around something the workaround is going away too.

Sorry for the confusion. I'll open another bug if I see duplicate calls to 
applyEditorValue().

*** This bug has been marked as a duplicate of 61413 ***
Comment 10 David Green CLA 2005-03-22 15:09:49 EST 
Can I request that this defect remain open until it is indeed fixed?
Comment 11 David Green CLA 2005-03-22 15:21:23 EST 
cancel that last request: presumably bug 61413 when addressed will resolve this
issue.