Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 78473

Summary: need to establish links/relationships between profiling types and agents/launch configuration types
Product: z_Archived Reporter: Eric Labadie <labadie>
Component: TPTPAssignee: amehrega
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P1 CC: ashishp, qiyanli
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows 2000   
URL: http://www.eclipse.org/tptp/groups/Architecture/documents/features/hf_78473.html
Whiteboard:
Bug Depends on: 90754    
Bug Blocks:    

Description Eric Labadie CLA 2004-11-11 22:54:00 EST
The profiling types / sets design does not work well with some IBM products. 
The original design was not properly reviewed, and does not link profiling 
types with agent types or launch configurations. As a result, RPA users have to 
know to pick the J2EE Performance Analysis type in order for things to work. If 
they pick the other sets, like Execution History, etc, then nothing happens. 
The same applies to the reverse, if trying to profile WAS using the piAgent, 
you can't select the J2EE Performance Analysis set/type (as counter-intuitive 
as that may seem) because it's only for the other IBM agent. To do this 
correctly, we would need to establish links/relationships between profiling 
types and agents/launch configuration types, so that when you try to profile 
your J2EE app using the IBM agent, you only get the profiling sets/types that 
apply to the IBM agent.
Comment 1 Valentina Popescu CLA 2004-11-12 10:14:17 EST
Mapping profiling sets to agent types is not a complete solution since all 
profiling agents, PI or J2EE, share the same profiling type.
I am upgrating the defect to a feature so that we make sure the solution for 
this problem is getting enough consideration and go to the right channels for a 
complete design.
Comment 2 Curtis d'Entremont CLA 2004-11-12 10:36:30 EST
Actually, the profiling types don't apply to the J2EE request profiler.. the 
profiling set selection page (overview tab) is disabled in this case to avoid 
user confusion. The profiling types for memory, coverage, and execution have 
hardcoded piAgent options in them that don't apply to the J2EE request profiler.

The design I was considering was more along the lines of linking profiling 
types to launch configs / agent types.. and only profiling sets with the right 
profiling types would show up. It wouldn't be a 1-1 mapping, as some profiling 
types could be shared among different agents / launch configs. This is only one 
of the problems with the design, there are numerous other things lacking, like 
page display notification, querying the profiling type UIs for error messages 
and whether or not they are complete (finish button enabled), etc.
Comment 3 Valentina Popescu CLA 2005-01-30 11:04:39 EST
The sizinf for this feature is 8 weeks and there are not enough resources to be 
included into the 3.3 or 4.0 plan if not already committed; moving feature to 
4.1
Comment 4 Valentina Popescu CLA 2005-04-05 14:44:16 EDT
update priority
Comment 5 Ruth Lee CLA 2005-07-12 10:58:14 EDT
Deferring from 4.1 as per the official 4.1 enhancement plan.
http://eclipse.org/tptp/home/project_info/featureplans/features.php?source=All&project=All&release=4.1&file=TPTPFeatures_4.1.xml
Comment 6 Curtis d'Entremont CLA 2005-07-12 13:23:13 EDT
Setting to next release. This one is important for us.
Comment 7 Curtis d'Entremont CLA 2005-10-05 13:20:26 EDT
One more thing to add about this one. Consider the case where we are not
profiling live, but importing data from some persistence mechanism like a
database, and populating the model with this data.. where there is no agent to
do the real-time equivalent (i.e. you can only view historical data, no live data).

In this case we would still want to show a profiling type, possibly a special
one that only appears when importing this kind of data. However, we do not want
the profiling type to show up for any of the agents because you can't get this
kind of data live; so I should be able to define a profiling type not linked to
any launch config or agent, however still be able to show it in the Profiling
Monitor.

This might be assumed from the feature description, but I just wanted to make
sure the feature would allow this.
Comment 8 Sri Doddapaneni CLA 2006-01-10 18:58:59 EST
Targeting to 4.2i1. Owners plese adjust for any exceptions by targeting to 4.2i2.
Comment 9 amehrega CLA 2006-01-10 19:20:30 EST
This feature along with many other features will be knocked out by 93212, which is targeted to i2.

I'll target this one to i2 as well.

Comment 10 amehrega CLA 2006-03-31 17:47:08 EST
Fix in cvs.  Refer to figure 2.2 in http://www.eclipse.org/tptp/home/documents/tutorials/datacollection/launch-extensions/extending-launch-configuration.html for the relationship of the entities involved.
Comment 11 Ashish Patel CLA 2006-11-16 14:15:24 EST
Closing.