| Summary: | Toolbar toggle buttons are confusing | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Nick Edgar <n.a.edgar> |
| Component: | UI | Assignee: | Martin Aeschlimann <martinae> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P2 | CC: | hudsonr, kai-uwe_maetzel |
| Version: | 2.0 | Keywords: | usability |
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | other | ||
| Whiteboard: | |||
|
Description
Nick Edgar
The debug view should take the same approach. See bug 6388. Usuability not accessibility issue The debugger has been updated to the intuitive toggle behavior. The outliner should be updated to this behavior as well. The question of the dynamic tooltips has not yet been addressed in the debugger, but I agree with Nick's suggestion. Dynamic tooltips on toggle buttons are a bad idea. The approach currently taken by JDT UI is consistent: When a button is checked a filter is active. Following your approach means that two buttons (Show Fields, Show Static Members) are "inverted" filters, whereas (Show Only Public Members) is a filter. For the user looking at the artwork this is not plausible. There are two alternatives: a) We introduce buttons for private, protected, and default members -> overloads the toolbar. b) Instead of "Show Only Public Members" we introduce "Show Non-Public Members" -> requires new artwork. I agree if you mean the user's notion of filter (based on the labels, which state what is shown), rather than the implementation filters (which hide things). If the label says "Show Static Members" then static members should be shown when the button is pushed in. Likewise, I don't have a problem with the label "Show Only Public Members". It should show only public members when pushed in. The defaults are up to you. I believe currently the defaults are hide statics and finals, and also show non-public members. So none of the buttons would be pushed in. Please see comments above. *** Bug 9853 has been marked as a duplicate of this bug. *** From the ATC, the JDT was just following the UCD. So I think the UCD needs to be modified ASAP to match these changes. Sorry, what does UCD expand to? Do you mean the Eclipse UI design guidelines? *** Bug 9860 has been marked as a duplicate of this bug. *** We will change the filter actions as follows (basically going with Kai's
proposal b)
Field:
pressed = shows the fields
unpressed = doesn't show the fields
tooltip: Show Fields
Static:
pressed = shows the static members
unpressed = doesn't show the static members
tooltip: Show Static Members
Public:
pressed = filters non-public members
unpressed = no filtering
tooltip: Public Members Only
we have ordered new artwork for the public filter, to
emphasize that it is a filter, i.e., public sphere with a filter adornment.
We will also change the tooltips to have static text only.
Recommend using "Show Only Public Members" for tooltip instead of "Public Members Only". fixed > 20020502 according the latest UI guide lines we should still use dynamic tooltips. Reopen so that we will revisit. Nick, UCD = User centered design = Julian et. al. The usability team said they would change the UI guidelines. Please *don't* undo these fixes just because the documentation is out-of-date. Is there a component that this can be moved to for "UCD"? The old behaviour (hide fields / statics) without dynamic tooltips is back again. See bug 15946 > 20020514 |