Bugzilla – Full Text Bug Listing
| Summary: | [Operations] No user feedback on replace with | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Kent Johnson <kent_johnson> |
| Component: | CVS | Assignee: | platform-cvs-inbox <platform-cvs-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 | Keywords: | helpwanted |
| Version: | 3.0.1 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | stalebug | ||
|
Description
Kent Johnson
In turns out we do show a busy cursor in the replace with operation. Are you sure you had no feedback at all? If this is true, it either happened before our code was run (perhaps during classloading for the CVS plugin) or there was a failure to show the busy cursor. This operation can take a while but in most cases it does not. For this reason, I hesitate to show a progress dialog all the time. We could use the IProgressService API to show a delayed progress dialog but we would need to refactor the code a bit to ensure that prompting does not occur inside the runnable passed to the progress service as this can cause deadlock on some platforms. There may have been a busy cursor but that's useless when something can take over a minute to execute... especially when you expect an immediate prompt to let you choose the version to replace. Instead of asking the user if you can replace his changes, why not always make him confirm that this operation will replace his changes? That way you don't waste time finding out if he has any changes in the first place. Regarding comment #2, because we used to do that and got plenty of bug reports requesting to get prompted only when there were really outgoing changes. However, It may be possible to defer the checking until we are traversing the file system to purge any dirty resources before the replace. This part is done in the background so would not block the user until the prompt occurred. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |