Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 75717

Summary:	Avoid setting decorator colours
Product:	[Eclipse Project] Platform	Reporter:	Billy Biggs <billy.biggs>
Component:	Team	Assignee:	Silvio Böhler <silvio_boehler>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	douglas.pollock, jared_burns, sma
Version:	3.0
Target Milestone:	3.1
Hardware:	PC
OS:	Linux-GTK
Whiteboard:
Bug Depends on:	73374
Bug Blocks:

Description Billy Biggs

2004-10-06 11:20:48 EDT

3.1M2

The CVS label decorator seems to currently set the foreground and background
colours to be the list foreground and background.

On Windows, when an item is selected, the selection foreground and background
override any colour settings for the selected rows.  However, on GTK+ the text
foreground colour overrides the selection foreground colour, and while the
selection background colour overrides any set background, this is broken when
the tree loses focus.  See the screenshots in bug 74769, and bug 49617/bug 30994
about the problems with GTK+ tree views.

To at least work around these problems, I think it would be best to avoid
setting the foreground and background colour unless they actually differ from
the default list foreground and background.

Comment 1 Jean-Michel Lemieux

2004-10-06 13:06:19 EDT

That was the designed behavior - use the system defaults if none are specified.
But the implementation may of been different :)

Comment 2 Jean-Michel Lemieux

2004-10-06 16:06:20 EDT

Yes now I remember - themes definitions can't be enabled/disabled by the user so
plug-ins can't, unless they build their own, tell if the user has chosen to
override the default colors/fonts or has set them. Currently the cvs label
decoration colors default to list_foreground and list_background. 

We will have to solve this for 3.1 though, not M3.

Comment 3 Billy Biggs

2004-10-12 15:06:46 EDT

*** Bug 76117 has been marked as a duplicate of this bug. ***

Comment 4 Jean-Michel Lemieux

2004-10-15 10:50:09 EDT

*** Bug 76342 has been marked as a duplicate of this bug. ***

Comment 5 Michael Valenta

2004-11-30 13:46:24 EST

Moving from M4 since we cannot address this without API from the theme support 
for determining whether the font was chaqnged or not.

Comment 6 Michael Valenta

2004-12-17 12:11:18 EST

*** Bug 81534 has been marked as a duplicate of this bug. ***

Comment 7 Michael Valenta

2004-12-17 12:12:25 EST

Bug 81534 also points out a problem with fonts when decorators are used in 
dialogs.

Comment 8 Silvio Böhler

2005-01-19 15:20:48 EST

Fixed in HEAD - the CVS font and color decorations can now be disabled globally
on the CVS label decorators preference page.

Comment 9 Michael Valenta

2005-04-28 14:07:31 EDT

In addition, I have changed the preference to be off by default.