Bugzilla – Full Text Bug Listing
| Summary: | Compute download-size and install-size for feature.xml | ||
|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Nick Edgar <n.a.edgar> |
| Component: | Build | Assignee: | pde-build-inbox <pde-build-inbox> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | aniefer, birsan, caniszczyk, contact, digulla, elias, gunnar, mober.at+eclipse, pascal, phil.kursawe, pombredanne, pyvesdev, robbinsj, sonia_dimitrov |
| Version: | 3.0 | Keywords: | helpwanted |
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 2000 | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 131802 | ||
|
Description
Nick Edgar
It also complained that the update wasn't digitally signed. Not a problem for me, since I trust eclipse.org <g>, but it would be nice to avoid this hiccup too. Sonia, is it possible to build the features so that the size of plugins is computed and set inside feature.xml? As for signing, I remember there is some support in pde to do this as well. Moving to PDE Build for investigation. *** Bug 44638 has been marked as a duplicate of this bug. *** *** Bug 65787 has been marked as a duplicate of this bug. *** *** Bug 149364 has been marked as a duplicate of this bug. *** *** Bug 185659 has been marked as a duplicate of this bug. *** Phillipe, do you have code that you're willing to contribute for this one? You mentioned something in a previous bug report. I'd like to see this available out of box in 3.4 (In reply to comment #8) > Phillipe, do you have code that you're willing to contribute for this one? You > mentioned something in a previous bug report. I'd like to see this available > out of box in 3.4 Chris: I dove some code which does that . I'll give pointer to it next week. i would be happy to contribute! setting target to 3.4M1 as a reminder Hi, I would be happy to test and/or evaluate your code if you post it, Philippe, as I think it would be really great to include it in 3.4 ASAP ! :) Hey, is there anybody out there ? ;-) Philippe, is your code running OK againt 3.4M2 ? Would you want me to test it before integration ? Regards Hey Phillppe, this would be a nice addition for 3.4 Note that for Ganymede, this significantly more complicated than simply setting download sizes in the feature.xml at build time. Signing jars modifies their sizes, and the feature.xml files can not be modified after signing. To get plugin sizes, plugins would need to be signed separately from features, the features then updated later with the plugin sizes. To get feature sizes, features would need to be signed in depth first order of inclusion, so that the containing features could be updated before being signed. Also we are hoping that Ganymede will be delivered using p2 where this problem is handled. Comment #9 mentions some code for this feature - is it available? Since 3.4M1 is over already, could a proper target milestone be found? Regarding comment #14 (change in size due to signing), I see two options: a) Ignore that change since it is relatively small and the sizes are given in KByte measure only anyways so they are not 100% accurate b) Perform a two-stage bootstrapping approach: Have build #n create an output file that lists each plugin and feature with the size of the signed (for install size) / signed+packed (for download size) size. Have that output file stored in a well-known place or checked in. Have build #(n+1) read this file and apply the sizes to the plugins and features. (In reply to comment #16) > a) Ignore that change since it is relatively small and the sizes are > given in KByte measure only anyways so they are not 100% accurate I am in favor of treating these sizes as approximations only. (I did not realize they were written in KB in the feature). Doing this the only signing we have to worry about is the JNLP signing that occurs in the build proper, and not the signing that occurs outside of pde.build. Are sizes only specified on included plugins? If they are not specified on imported features then this also simplifies things. Mass change for PDE Build bugs tagged with "helpwanted". PDE build is not actively enhanced, hence I close these bugs as wontfix. Please reopen if you want to contribute a patch. |