Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 74727

Summary: [Startup] Workspace prompt preference does not stick
Product: [Eclipse Project] Platform Reporter: Nick Edgar <n.a.edgar>
Component: UIAssignee: Andrew Eidsness <eclipse>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: eclipse
Version: 3.0   
Target Milestone: 3.1 M3   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Nick Edgar CLA 2004-09-22 16:33:53 EDT
build I20040921-2000

- In the "Startup and Shutdown" pref page, uncheck "Prompt for workspace on
startup".
- OK
- Open the pref page again
- It's still checked

I'm running with -data, so I don't see the prompt anyway.
Comment 1 Tod Creasey CLA 2004-09-23 10:53:25 EDT
This is an issue with ChooseWorkspaceData not being persisted but not 
preferences in general.
Comment 2 Andrew Eidsness CLA 2004-09-23 11:07:06 EDT
This problem stems from three decisions:

1. The workspace launcher information is stored in a private file.
2. The private file is not created when eclipse is started with -data.
3. The code in the preference store not create the file if it does not exist.

Changing any of these decisions will fix this bug.  I think that the proper 
solution is to get rid of the private file and store the information in the 
config area instead (see bug 72341).
Comment 3 Nick Edgar CLA 2004-09-23 14:57:03 EDT
Makes sense to me.
Comment 4 Andrew Eidsness CLA 2004-09-28 10:52:21 EDT
If the preference does not exist (e.g., on the first run) then the preference 
store tries to access the instance area, which causes an exception.  This bug 
cannot be resolved until bug 75175 has been fixed.

Work can still continue on this bug (i.e., I'm not blocked) since its possible 
to ensure there are values in the config area (its only the first run that is 
broken).
Comment 5 Andrew Eidsness CLA 2004-09-29 09:55:44 EDT
I've changed the ChooseWorkspaceData class to use config area preferences to 
store its data.  To help with the transition, the code that reads the values 
looks for the file if the preferences are not found.

Submitted to HEAD.
Comment 6 Billy Biggs CLA 2004-11-03 16:57:47 EST
Verified in I200411022000.