Bugzilla – Full Text Bug Listing
| Summary: | [Repo View] CVS Tag deletion | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Ullrich Pollähne <u.pollaehne> | ||||||||
| Component: | CVS | Assignee: | platform-cvs-inbox <platform-cvs-inbox> | ||||||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P4 | CC: | andrew_cornwall, angvoz.dev, bugs, clg-business, daniel_megert, dominik.skorka, douglas.pollock, iurii.volchyn, jcormier, jcsahnwaldt, malgorzata.tomczyk, Mark.O.Gruener, ma_s, nitindhall, piotr.findeisen, remy.suen, steen.lehmann, Szymon.Brandys, tomasz.zarna, xiong.zhang | ||||||||
| Version: | 3.0 | Keywords: | helpwanted | ||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | stalebug | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Ullrich Pollähne
You can run from the cvs command line: cvs tag -d <tag name> We didn't want to expose this as it is dangerous, I would prefer making our dialogs more scalable with relation to large sets of tags. Yes, deleting tags is dangerous but there are more actions with CVS that should be executed with caution. ;-) The tag deletion is (for me) the only reason to have a command line CVS. I would like to second the request for the delete tag feature. For me it's not a question of too many tags and/or a scalable dialog. And as far as I can tell, eclipse doesn't come with a command-line "cvs" program, so when running on a windoze box, there's no fallback. Here's the use case: I need to delete a Java file that has a critical tag, the one used to say "build this version." I must delete the tag before deleting the file, otherwise that file will reappear when my build coordinator exports the repository using the version tag. But there's no way to do it in eclipse. Perhaps this feature could be hidden on an "Advanced" tab, or the preferences could be extended so the delete-tag item is not offered unless a "Show all" preference is chosen. To get me through today's problem, I resorted to win cvs: checked out the whole beast of a project into a separate work area, used the WinCVS "delete tag" feature, then refreshed the Eclipse work area. What a pain. *** Bug 41965 has been marked as a duplicate of this bug. *** We also wish to have this feature: 1) Goto the CVS perspective 2) Select a file, set of files, directory, set of directories 3) Right click - Tag removal 4) Enter the tag name and press OK 5) Display something about the tag removal status I failed to mention our real problem. Our build process uses command line CVS and is based on tags. When we have files that are in the CVS attic that have tags we want to be able to remove the tags. I also need this feature, so I browser around in Team -> Tag as Version... and by clicking on Details and Configure Tags... I got into a dialog where I could select a remembered tag and supposedly remove it (Button 'Remove'). However, this doesn't work (Eclipse 3.2) Either I'm wrong with my assumption or the UI is confusing me... The Remove you found is really just a Forget (i.e. it tells Eclipse to remove the tag from it's local cache). We'll look into addressing this for 3.4. *** Bug 192624 has been marked as a duplicate of this bug. *** Please count my vote too. It is a bit annoying to switch from Eclipse to an external CVS client just to remove a tag. I think that "Tag resources" dialog can gain yet another option like "Remove" next to "Move tag if it already exists". Obviously the checkboxes would not make sense anymore here, so a radial button may be a better choice instead. If a user does not select clearly a tag to remove then the existing one (on the files to removal) could be taken. This one has been waiting for a volunteer. Lowering the priority to the value appropriate for 'helpwanted' issues. Created attachment 115656 [details]
The patch to fix this bug(Based on the code 20081020)
I just attached the patch to fix this bug.
I hope you'll accept it.
Created attachment 115657 [details] RemoveTagPlugin(For Eclipse 3.4.0) Before eclipse platform team accepts the patch, you can try this plugin instead. For more details, you can refer to http://blog.zijinshi.cn/frank/archives/8. It would also be interesting to have the context menu on the revision in the History view (cvs page). In attached patch and plugin, the context menu for repository view is not added yet, I'll add the feature later. Created attachment 115776 [details] Patch to fix this bug(20081022) After applying the patch, user can find "Remove Tag..." action via the 2 menus: 1.Context menu Team->Remove Tag... 2.Repository view. Of course, the code includes the feature(excluding the menu in comment #14), but needs to be tidied and optimized. For the benefit of those who are waiting for this to end up in the official release, you can write an Ant task that does:
<cvs cvsRsh="${ssh_exe}" cvsRoot=":ext:${user}@${cvs.server}:${cvs.repo}" command="rtag -d tag-to-delete module-to-delete-tag"/>
That at least will eliminate the need for the command line tool.
*** Bug 276614 has been marked as a duplicate of this bug. *** Gosia, could you please have a look at the proposed patch (comment 16) and see if it can be applied. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. If the bug is still relevant, please remove the stalebug whiteboard tag. |