Bugzilla – Full Text Bug Listing
| Summary: | [Dialogs] ErrorDialog resize behaviour should be improved | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Marcus Olk <molk> | ||||||
| Component: | UI | Assignee: | Susan McCourt <susan> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | athoma22, BMYSZAJJJQPZ, eclipse, feng_sian, jli1, jtatchel, konigsberg, markus.kell.r, michael.giroux, Michal.Tkacz, mmo, Olivier_Thomann, remy.suen, Tod_Creasey, yharms | ||||||
| Version: | 3.0 | Flags: | susan:
review?
(Tod_Creasey) |
||||||
| Target Milestone: | 3.4 M1 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Marcus Olk
Created attachment 14145 [details]
Screen shot of ErrorDialog resize flaws
*** Bug 67773 has been marked as a duplicate of this bug. *** *** Bug 122698 has been marked as a duplicate of this bug. *** *** Bug 133114 has been marked as a duplicate of this bug. *** *** Bug 140453 has been marked as a duplicate of this bug. *** look at this for 3.3, there have been many bugs opened on this issue *** Bug 174567 has been marked as a duplicate of this bug. *** investigate during RC1 Created attachment 66563 [details]
proposed patch to ErrorDialog
The attached patch fixes the vertical resize so that the details area grabs all the extra space.
The code change to fix the vertical resize problem (which has been reported in many duplicate bugs) is trivial, but there may be downstream clients relying on this behavior. ErrorDialog creates an empty dialog area (under the message area and above the button bar). This area was grabbing vertical space. However, there are many subclasses that override the creation of the ErrorDialog dialog area to add content to this area. If they are calling super.createDialogArea() and adding content, they may be relying on the vertical space grab. Tod and Markus, what are your thoughts? This would be a nice polish fix for ErrorDialog but potentially "unpolishing" of subclasses and perhaps late to be changing this. If we don't do it now, I can do it first thing in 3.4. I would feel better if we did this for 3.4. There are a lot of ErrorDialog subclasses this might affect. I've marked this 3.4 and will release this patch very early in the 3.4 cycle so that we can finally fix this bug. *** Bug 189724 has been marked as a duplicate of this bug. *** *** Bug 104841 has been marked as a duplicate of this bug. *** *** Bug 110625 has been marked as a duplicate of this bug. *** Fixed in HEAD (3.4 Stream) > 20070625. I'll post a heads up in platform-ui-dev to give a heads up to those who might have been relying on the old behavior. *** Bug 169630 has been marked as a duplicate of this bug. *** verified in WinXP, I20070807-0010 *** Bug 209637 has been marked as a duplicate of this bug. *** |