Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 71558

Summary:	TODO markers in JSP Scriptlets are not shown
Product:	[WebTools] WTP Source Editing	Reporter:	Andrey Loskutov <loskutov>
Component:	jst.jsp	Assignee:	Nitin Dahyabhai <thatnitind>
Status:	CLOSED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	david_keller_fr, gunnar, jlsoper, nsand.dev, thatnitind
Version:	0.7	Keywords:	plan
Target Milestone:	3.1 M1
Hardware:	All
OS:	All
Whiteboard:	EaseOfUse

Description Andrey Loskutov

2004-08-06 08:28:15 EDT

"TODO" markers are shown in jsp files only inside jsp scriplet comments,
like here:
<%-- TODO fix me --%>, 
but not inside jsp scriplets like:
<% 
// TODO fix me 
System.err.println("test");
%>

Comment 1 David Williams

2004-08-11 15:48:26 EDT

Appreciate the comment. I can confirm we did not (intend) to cover this case in 
current code, but you saying you need it will increase it's priority in future 
work.

Comment 2 Andrey Loskutov

2004-08-11 16:40:59 EDT

I saw many pieces of code (within really long jsp scriplets) where this "TODO" 
feature would assist us greatly.

Comment 3 David Williams

2004-12-08 23:44:43 EST

just fixed up owner to specific inbox

Comment 4 Nitin Dahyabhai

2005-06-27 13:45:26 EDT

Changing severity to enhancement, since this is a new feature.

Comment 5 David Williams

2005-06-27 21:49:30 EDT

Ted ... I was wondering if this sort of problem would interest you? 
Since you are already working with translated JSPs, I was hoping a small
special purpose parser might suffice? Or ... get the JDT's AST and look 
for commnets?

I'd be interested to know what if you think feasible for .7, since so many votes. 
(Plus .. there's alwasy JavaScript that need to be done too). 

Nitin, Phil, and I can review your general approach and designs and help in
anyway we can ... should you choose to accept it.

Comment 6 Andrey Loskutov

2005-09-26 15:02:25 EDT

Hi Ted, Nitin.
Actually there is a similar bug 107527 assigned to Nitin. I think this one is 
the same, therefore the other one should be considered as duplicated.

P.S.
Did you have any plans for implementing this feature in the near future?

Comment 7 David Williams

2006-03-04 00:41:52 EST

Walter, interested in fixing this bug?

Comment 8 David Williams

2006-09-23 19:03:17 EDT

*** Bug 107527 has been marked as a duplicate of this bug. ***

Comment 9 Nitin Dahyabhai

2007-09-13 03:09:20 EDT

This is a wonderful idea, but for now we don't have the time to do it.  A good patch would be eagerly accepted, though

Comment 10 Nitin Dahyabhai

2008-07-25 12:13:59 EDT

Implemented in HEAD, although it uses the Java Compiler's Task Tag values.

Comment 11 Nitin Dahyabhai

2008-07-28 16:57:59 EDT

*** Bug 221857 has been marked as a duplicate of this bug. ***

Comment 12 Nick Sandonato

2008-11-07 09:42:25 EST

Verified in 3.1M3-20081107075001.

Comment 13 Nitin Dahyabhai

2009-09-10 15:55:52 EDT

closing