Bugzilla – Full Text Bug Listing
| Summary: | Action Cleanup/Dispose | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Darin Swanson <Darin_Swanson> |
| Component: | Debug | Assignee: | Platform-Debug-Inbox <platform-debug-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | n.a.edgar |
| Version: | 2.0 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 2000 | ||
| Whiteboard: | |||
| Bug Depends on: | 7235 | ||
| Bug Blocks: | |||
|
Description
Darin Swanson
Agreed. There should be an action package. Where possible, actions should be contributed via plug-in XML rather than hardcoded by a view. Also, action updating (enabling) should be handled by the action rather than the view where possible. This reduces the cohesion between actions and views, and makes the actions more portable/reuseable. Not sure if a bug has been filed against the workbench, but it is crucial that "view action delegates" get a "dispose" callback such that they can remove themselves as event listeners, etc. This is one roadblock I have found in using action contributions effectively. A dispose callback would work for bug 7010 as well...the reason I wanted to know when the last editor was closed was to remove the action delegate as a listener. The current workaround for not having a dispose call on an IViewActionDelegate is to add the action as a IPartListener. When the part closes, this is treated as a dispose. Deferred until 7235 is fixed. Resolving to later. We are using the IActionDelegate2 interface and the #dispose method this provides. Closing. As of now 'LATER' and 'REMIND' resolutions are no longer supported. Please reopen this bug if it is still valid for you. |