| Summary: | [Wizards] Poor error handling in Change ASCII/Binary Property action | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Patrick Ruckstuhl <patrick> |
| Component: | CVS | Assignee: | platform-cvs-inbox <platform-cvs-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 | Keywords: | helpwanted |
| Version: | 3.0 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | stalebug | ||
Some additional info that I forgot: The logmail is sent and the revision number is increased, but the ascii/binary property doesn't change. The code in question commits file contents as required and then admins the file. My guess is that the warning on the commit caused the action to stop and the admin phase was never run. Ideally any errors should be detected and any succesful committed files should be admined. However, this is complicated by the fact that there is no definitive specification of the possible commit failures (especially when server scripts are involved) so the only way to figure out the possible errors is to reproduce them and then write a custom parser to translate the resulting text messages into the proper information (as we do for everything else). Given that the workaround is simply to rerun the action with the proper comment, I wouldn't give this bug a very high priority. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |
If I want to change the ascii/binary property on some files, the action does cancel with the warning messages from the cvs server. (to be exact the message is: "cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings.") The warning is generated because the format for loginfo scripts changed and we use a script that needs the old format. The same warning comes also if I commit a file, but there it only shows up in the console and doesn't block the operation.