Bugzilla – Full Text Bug Listing
| Summary: | (Plat)Can delete default profiling sets and can't restore them. | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Geary Ridings <gridings> |
| Component: | TPTP | Assignee: | amehrega |
| Status: | CLOSED INVALID | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | gweidner, popescu |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | closed460 | ||
| Bug Depends on: | 90754 | ||
| Bug Blocks: | |||
|
Description
Geary Ridings
Nuts! Just discovered that if I close and restart Eclipse that the "deleted" profiling sets come back. So we're not really able to delete the profiling sets, but then we shouldn't give the user the impression that we are. Java, one way to do this is using a "Restore Defaults" button at the bottom of the Overview tab under the Profiling tab. This would reset all the profiling sets to the defaults. Look around at other pages, like preference pages, wizards to see where they usually place this button. The whole implementation of the ProfilingSetManager need to be reviewed as I also see the following problems: 1. When user create new profile set without applying them on any actually launch (ie. click Apply and Close but not Profile), the new set is not persisted anywhere so it is lost when relaunching workbench. 2. There is no way to 'restore' the 3 out-of-the-box profiling sets to their default settings. eg. provide a 'restore default' on profiling set listings. 3. The 3 out-of-the-box profiling sets are restored everytime workbench relaunch ignoring any removal in last workbench session. 4. The definition of 'Revert' need to be defined, does it revert any editing on a profiling set? eg. Select a profiling set, select edit and include one more profiling type for the set editing. 5. Profiling sets should be persisted independent of Launch configuration. propose to review the whole implementation of profiling set in 3.3 retarget milestone based on Harm's approval on defect re-categorize. Grouping 64265 under the same feature : Inaccurate filter set contents after Cancel from Edit Profiling Set Dialog Steps to reproduce: 1) Change a filter value (e.g., change the visibility rule from Exclude to Include for java* filter for the Default filter set). 2) Click Cancel on the Edit Profiling Set dialog. 3) Before dismissing the Launch Dialog, click Edit again to re-display the Edit Profiling Set dialog. 4) Click Next to display the Filters page. Observe that the change made in step 1 is still shown although Cancel was clicked. Expect original unchanged value to be shown. 5) Click Cancel to dismiss the Edit Profiling Set dialog. 6) Click Close to dismiss the Launch Dialog. Note if Profile is clicked, the original unchanged filter value is used (which is good since Cancel was clicked) but the display inconsistency could be confusing for the user. 7) Re-display the Launch Dialog. 8) Display the Edit Profiling Set Dialog. 9) Click Next to display filters. Observe correct expected unchanged value is displayed. Note the inconsistency only occurs when editing a filter's content (Edit or direct table modification) or changing the filter order (Up/Down buttons). Adding or removing a filter from the filter set in step 1 was correctly cancelled (i.e., original unchanged filter contents displayed in step 4). This is happening because the working copy of the filters used in the Edit profiling set wizard is not completely disjoint from its original (using a different container, but the same instances). This will have to be reworked *** Bug 64265 has been marked as a duplicate of this bug. *** Keep target as emptry for now and will raise to RG for proposed new target release Deferring from 4.1 as per the official 4.1 enhancement plan. http://eclipse.org/tptp/home/project_info/featureplans/features.php?source=All&project=All&release=4.1&file=TPTPFeatures_4.1.xml The concept and all supported APIs of profiling sets has been deprecated. Setting the target to future but this will likely be marked as invalid once the launch configuration's refactored APIs are checked in. Marking this as invalid because profiling sets were taken out since TPTP 4.2i2 As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |