Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 67620

Summary:	Breakpoints should not be shown in the overview ruler
Product:	[Eclipse Project] Platform	Reporter:	Erich Gamma <erich_gamma>
Component:	Debug	Assignee:	Kevin Barnes <cocoakevin>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	darin.eclipse
Version:	3.0
Target Milestone:	3.0 RC3
Hardware:	PC
OS:	Windows XP
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=498493 https://bugs.eclipse.org/bugs/show_bug.cgi?id=498497
Whiteboard:

Description Erich Gamma

2004-06-17 09:16:41 EDT

The out of the box annotation setting for breakpoints is to show them in the 
overview ruler. I assume this is an oversight. We didn't do this in 2.1. It is 
highly confusing since breakpoints are now easily confused with tasks in the 
overview ruler. 

please consider for RC3

Below is the change to the corresponding annotation spec:

   <extension
         point="org.eclipse.ui.editors.markerAnnotationSpecification">
      <specification
            colorPreferenceValue="0,0,255"
            annotationType="org.eclipse.debug.core.breakpoint"
            colorPreferenceKey="breakpointIndicationColor"
-->         overviewRulerPreferenceValue="false"
            presentationLayer="3"
            label="%BreakpointMarkerPreference.label"
            textPreferenceValue="false"
            textPreferenceKey="breakpointIndication"
            verticalRulerPreferenceKey="breakpointVerticalRuler"
            verticalRulerPreferenceValue="true"
            overviewRulerPreferenceKey="breakpointIndicationInOverviewRuler"
            icon="icons/full/obj16/brkp_obj.gif"
            
annotationImageProvider="org.eclipse.debug.internal.ui.BreakpointImageProvider"
>
      </specification>

Comment 1 Darin Wright

2004-06-17 10:29:50 EDT

Change in defualt pref value in debug ui plugin.xml.

Comment 2 Darin Wright

2004-06-17 10:30:02 EDT

Please verify, Kevin.

Comment 3 Jared Burns

2004-06-17 11:27:04 EDT

Please reconsider.

I find breakpoints in the overview ruler useful. Besides helping me know what's
in my java file at a glance, I use the overview annotations to navigate to my
breakpoints quite often. Breakpoints are usually created in locations that are
interesting to the user; so it makes sense to make navigating to them easy.

If Erich has received complaints from users who are getting breakpoint
annotations confused with task annotations, we should just change the default
color of the breakpoint (or task) annotations.

Comment 4 Darin Wright

2004-06-17 11:34:29 EDT

Workaround - turn on the pref in the Annotations pref page.

Comment 5 Darin Wright

2004-06-17 14:53:35 EDT

Marking as fixed: it is easy to confuse a breakpoint with a task. We should 
minimize the potential for confusion for new users. Advanced users know how to 
enable showing the breakpoint in  the overview ruler.

Please verify, Kevin.

Comment 6 Kevin Barnes

2004-06-17 14:59:22 EDT

verified