Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 67469

Summary:	[Commands] The Save All menu item is broken
Product:	[Eclipse Project] JDT	Reporter:	Jeff Lawson <jeff>
Component:	Text	Assignee:	JDT-Text-Inbox <jdt-text-inbox>
Status:	RESOLVED DUPLICATE	QA Contact:
Severity:	normal
Priority:	P3	CC:	Kevin_Haaland
Version:	3.0
Target Milestone:	---
Hardware:	PC
OS:	Linux-GTK
Whiteboard:

Description Jeff Lawson

2004-06-16 11:21:36 EDT

Two problesm:

When just one .java file is dirtied, Save All doesn't become enabled.

When Save All is enabled and is then selected it doesn't become disabled.

Comment 1 Kevin Haaland

2004-06-16 14:48:27 EDT

Was not able to recreate can you describe the steps you used?

Were you using the latest 3.0 build?

Comment 2 Jeff Lawson

2004-06-16 16:02:59 EDT

I am using RC2 which was first available on Monday (not, as the web site 
indicates, on Friday).

BTW 1, I'm getting a lot of the following e.g. if I open Eclipse in a terminal 
I see it and at other times such as when inserting a breakpoint (a dialog pops 
up):

java.lang.NoClassDefFoundError
        at org.eclipse.jdt.core.dom.AST.newTryStatement(AST.java:1960)
        at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:2114)
        at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1855)
        at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1910)
        at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1813)
        at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:2055)
        at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:1837)
        at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:770)
        at org.eclipse.jdt.core.dom.ASTConverter.buildBodyDeclarations
(ASTConverter.java:336)
        at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:274)
        at org.eclipse.jdt.core.dom.ASTConverter.convert(ASTConverter.java:152)
        at org.eclipse.jdt.core.dom.AST.convertCompilationUnit(AST.java:253)
        at 
org.eclipse.jdt.internal.core.ReconcileWorkingCopyOperation.executeOperation
(ReconcileWorkingCopyOperation.java:81)
        at org.eclipse.jdt.internal.core.JavaModelOperation.run
(JavaModelOperation.java:700)
        at org.eclipse.jdt.internal.core.JavaModelOperation.runOperation
(JavaModelOperation.java:739)
        at org.eclipse.jdt.internal.core.CompilationUnit.reconcile
(CompilationUnit.java:1098)
        at 
org.eclipse.jdt.internal.ui.text.java.JavaReconcilingStrategy.reconcile
(JavaReconcilingStrategy.java:88)
        at 
org.eclipse.jdt.internal.ui.text.java.JavaReconcilingStrategy.initialReconcile
(JavaReconcilingStrategy.java:156)
        at 
org.eclipse.jdt.internal.ui.text.CompositeReconcilingStrategy.initialReconcile
(CompositeReconcilingStrategy.java:114)
        at 
org.eclipse.jdt.internal.ui.text.JavaCompositeReconcilingStrategy.initialReconci
le(JavaCompositeReconcilingStrategy.java:122)
        at org.eclipse.jface.text.reconciler.MonoReconciler.initialProcess
(MonoReconciler.java:104)
        at org.eclipse.jdt.internal.ui.text.JavaReconciler.initialProcess
(JavaReconciler.java:304)
        at 
org.eclipse.jface.text.reconciler.AbstractReconciler$BackgroundThread.run
(AbstractReconciler.java:169)
Unhandled event loop exception
Reason:
java.lang.NoClassDefFoundError



BTW 2, the Find/Replace dialog plus cut/copy is totally screwed in RC2 (rather 
than being just regular screwed prior to RC2). I don't know if this is related, 
i.e. something in the core creating havoc in several places. (I've reported 
this as BUG 67369.)

BTW 3: I have the latest integration builds of VE, EMF and GEF installed but I 
don't think they are causing the problems.

Comment 3 Kevin Haaland

2004-06-16 16:17:53 EDT

The noclassdef found error is suspicious. We really need to have reproducable 
steps in order to fix the bug.

Comment 4 Jeff Lawson

2004-06-16 17:16:53 EDT

I'm not saying that the noclassdef is the source of the Save All bug, its just 
that it happens a lot on my installation of RC2. In fact, upon further 
investigation I reckon it's _not_ associated with this Save All bug.


I can now characterise the Save All bug better: it happens only for large 
files, e.g. non-trivial source code with > 1000 lines. Small files don't cause 
the problem but large files do every time. So, it's not so much that > 1 files 
need to be dirtied for Save All to become enabled but that a 'small' file needs 
to be dirtied.

Comment 5 Douglas Pollock

2004-06-16 21:11:57 EDT

I cannot reproduce your bug.  Passing to JDT Core for comment about the 
exceptions in the log.

Comment 6 Frederic Fusier

2004-06-21 07:30:53 EDT

We have now a specific bug for the NoClassDefFoundError error: bug 67969, please
use it to follow this error (I will add reporter as CC of this bug...).
I put back this bug in JDT/UI land to let them decide to resolve it as
worksforme for the Save All menu item issue...

Comment 7 Dani Megert

2004-07-13 05:11:19 EDT


*** This bug has been marked as a duplicate of 67590 ***