Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 67067

Summary: [PropertiesView] PropertySheetViewer is applying Editor Value without active celleditor
Product: [Eclipse Project] Platform Reporter: Randy Hudson <hudsonr>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: CLOSED WONTFIX QA Contact:
Severity: major    
Priority: P3 CC: krzysztof.daniel, richkulp
Version: 3.0Keywords: helpwanted
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=327285
Whiteboard: stalebug
Attachments:
Description Flags
Solution proposal none

Description Randy Hudson CLA 2004-06-14 14:22:14 EDT 
In handleSelect(), PropertySheetViewer is calling applyEditorValue(); on the 
current celleditor.  But, the current cell editor:

1) may have already applied its value and disappeared (either ENTER was pressed 
or focus was lost)
2) may not be dirty, and should not apply unchanged values.

So this results in unnecessary application property values over and over.  In 
fact, if two or more items are selected, then isChanged is true always in 
PropertySheetEntry.

The result is that each act of selecting a TableItem in the PropertySheet 
causes a NO-OP command to be placed on the command stack.  This happens when 2 
or more items are selected.
Comment 1 Nick Edgar CLA 2004-06-15 10:59:44 EDT 
Randy, is this a regression from 2.1?
Comment 2 Randy Hudson CLA 2004-06-15 11:08:09 EDT 
I don't think it would be a regression, but I haven't checked.
Comment 3 Nick Edgar CLA 2005-03-30 16:04:26 EST 
Randy, would you be willing to look into a patch for this?
Comment 4 Randy Hudson CLA 2005-03-30 16:37:59 EST 
I'm still waiting for my patches to bug 46162 and bug 72556 to be "processed".
Comment 5 Nick Edgar CLA 2005-03-30 17:11:08 EST 
I'll have a look at 46162.  Doug needs to answer for 72556.

I'm only asking for a patch because the Properties view has been neglected for
so long, I suspect you're more up to speed on how best to fix it.
Comment 6 Krzysztof Daniel CLA 2007-01-30 07:51:31 EST 
Created attachment 57793 [details]
Solution proposal

Removes applying editor value if editor is not dirty.
Comment 7 Eclipse Genie CLA 2021-05-30 08:49:15 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.