Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 66737

Summary: Memento problem with org.eclipse.jdt.search.resultpage.grouping [search]
Product: [Eclipse Project] JDT Reporter: Nick Edgar <n.a.edgar>
Component: UIAssignee: Thomas M??der <t.s.maeder>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: daniel_megert, eclipse, Olivier_Thomann
Version: 3.0   
Target Milestone: 3.0 RC3   
Hardware: PC   
OS: Windows 2000   
Whiteboard:
Attachments:
Description Flags
Patch with the changed memento key none

Description Nick Edgar CLA 2004-06-11 13:48:00 EDT
build I20040611-0010

Saw the following entry in my log:

!ENTRY org.eclipse.ui 4 4 Jun 11, 2004 13:16:05.683
!MESSAGE Memento problem - invalid integer for key:
org.eclipse.jdt.search.resultpage.grouping value: TRUE
Comment 1 Dirk Baeumer CLA 2004-06-11 16:28:47 EDT
Steps to reproduce:

- start Eclipse with refresh workspace
- uncheck the limit to check box in the filter
- restart eclipse.

Interest is that the value is restored correctly.

Thomas we have to understand what is going on here. Please asses how critical 
this is for 3.0.
Comment 2 Thomas M??der CLA 2004-06-15 06:44:54 EDT
We're simply using the wrong key to put a string into a slot that previously
holds an Integer. The assignment fails, but since the default is true, and the
failure only occurs in the true case, the behaviour remains correct. 
It would fail in the case where we change the filtering to false and then back
to true.
Comment 3 Thomas M??der CLA 2004-06-15 06:46:13 EDT
Created attachment 12120 [details]
Patch with the changed memento key
Comment 4 Erich Gamma CLA 2004-06-16 05:08:30 EDT
+1 by Dirk & Erich
Comment 5 Dirk Baeumer CLA 2004-06-16 08:34:48 EDT
*** Bug 67421 has been marked as a duplicate of this bug. ***
Comment 6 Thomas M??der CLA 2004-06-17 08:54:17 EDT
released the patch. Review by Markus Keller.
Comment 7 Thomas M??der CLA 2004-06-18 03:54:24 EDT
*** Bug 67725 has been marked as a duplicate of this bug. ***
Comment 8 Dirk Baeumer CLA 2004-06-19 06:11:35 EDT
Verfified in I200406181804.