Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 66462

Summary: [KeyBindings] preference page: duplicate command names render with internal id
Product: [Eclipse Project] Platform Reporter: Markus Keller <markus.kell.r>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: CLOSED WONTFIX QA Contact:
Severity: major    
Priority: P3 CC: cocoakevin, douglas.pollock, hudsonr, jjsimpso, n.a.edgar, prakash, pwebster
Version: 3.0   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard: stalebug
Bug Depends on: 176235    
Bug Blocks:    
Attachments:
Description Flags
Patch v01 none

Description Markus Keller CLA 2004-06-10 03:02:31 EDT
I20040609-2000

The keybindings dialog appends the command ID to the command name iff command
names are not unique. Internal IDs should not be rendered in the UI. This has
already been detected in bug 66192 and bug 66259.

E.g. there's the following conflict:
Command 'Display' is defined in category 'Views' and 'Run/Debug' but
distinguishable by the (internal) command ids
'org.eclipse.jdt.debug.ui.DisplayView' and
'org.eclipse.jdt.debug.ui.commands.Display', respectively.

I guess the reason for this is that two equally-named commands would not be
distingushable in the 'Assignments' table of the 'Key Sequence' group. E.g.
entering Ctrl+Shift+D in the 'Key Seqence > Name' would not reveal which command
is bound.

One solution for this could be to append the category name in the Command column
of the Assignments table iff the command names are duplicate.
Comment 1 Debbie Wilson CLA 2004-06-16 10:24:25 EDT
*** Bug 67244 has been marked as a duplicate of this bug. ***
Comment 2 Randy Hudson CLA 2004-06-16 11:37:31 EDT
The user should not see plug-in IDs in the UI.
Comment 3 Markus Keller CLA 2004-06-18 07:26:28 EDT
Actually, the category name should *always* be rendered in the second
'Assignments' table.

When I type a key sequence, I'd like to see in which category the assigned
command is defined. Currently, I have to search through all categories to get
this useful information.
Comment 4 Randy Hudson CLA 2004-06-18 11:20:49 EDT
I agree, but "org.eclipse.jdt.debug.ui" is not a category name, it's an ID.
Comment 5 Douglas Pollock CLA 2004-07-12 11:48:09 EDT
*** Bug 69770 has been marked as a duplicate of this bug. ***
Comment 6 Douglas Pollock CLA 2004-07-13 16:22:05 EDT
I like the suggestion of using the category name as well as the command name.  
Perhaps another column in the table, and simply remove the extra text from the 
drop-downs. 
 
The keys preference page is slated for a complete overhaul (again), so this 
might wait until then. 
 
Re-assigning to Chris McLaren as he owns all of the bugs related to the keys 
preference page. 
Comment 7 Markus Keller CLA 2004-07-14 02:52:10 EDT
Just one more item to consider: It could happen that two independent plug-ins
declare a command with the same name in the same category.

In that case, the (NLSed) plug-in name could be appended to the command name.
This would completely avoid rendering internal ids in the UI. Declaring an
equally named and categorized command twice in a single plug-in should be
considered a bug.
Comment 8 Douglas Pollock CLA 2004-08-09 14:44:46 EDT
*** Bug 70069 has been marked as a duplicate of this bug. ***
Comment 9 Douglas Pollock CLA 2004-10-13 14:54:25 EDT
*** Bug 76193 has been marked as a duplicate of this bug. ***
Comment 10 Douglas Pollock CLA 2004-10-20 21:25:09 EDT
Taking all of Chris' [KeyBindings] bugs. 
Comment 11 Douglas Pollock CLA 2004-11-02 10:06:52 EST
This includes categories.  See the current "Source" / "Source" duplication in 
M3. 
Comment 12 Douglas Pollock CLA 2005-04-12 11:37:01 EDT
The preference page re-work has been pulled for the 3.1 plan to work on performance.
Comment 13 Michael Van Meekeren CLA 2006-04-21 13:14:33 EDT
Moving Dougs bugs
Comment 14 Paul Webster CLA 2006-09-28 15:13:36 EDT
Is this still a problem in 3.3?

PW
Comment 15 Markus Keller CLA 2006-09-29 06:12:57 EDT
Yes. There are e.g. 2 'Source > Show Tooltip Description' commands, which are indistinguishable now. The internal id is not rendered any more, but that's even worse than showing it.
Comment 16 Paul Webster CLA 2009-03-02 11:39:19 EST
Updated as per http://wiki.eclipse.org/Platform_UI/Bug_Triage
PW
Comment 17 Prakash Rangaraj CLA 2009-12-10 03:51:50 EST
Created attachment 154210 [details]
Patch v01

In the conflict viewer, we can display the category and when there is a conflict, we can append the descriptions of the commands.
Comment 18 Eclipse Webmaster CLA 2019-09-06 15:30:22 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 19 Eclipse Genie CLA 2021-09-04 15:29:39 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.