Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 65667

Summary: [Navigator] (regression) Usability/Accessibility - Focus does not remain on file after rename in Navigator
Product: [Eclipse Project] Platform Reporter: Pat McCarthy <patmc>
Component: UIAssignee: Nick Edgar <n.a.edgar>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: eclipse, michaelvanmeekeren
Version: 3.0Keywords: accessibility, usability
Target Milestone: 3.0 RC2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 54296    
Attachments:
Description Flags
Patch to RenameResourceAction none

Description Pat McCarthy CLA 2004-06-03 23:03:03 EDT 
I can do the following just fine in 2.1.1:

Select a file in navigator view
Press F2 to trigger rename
Type in new name (revise last part of name) and press enter
Focus/selection remains on the file
(Same for folders)

In 3.0:

After the rename and pressing enter focus has jumped to the new wizard toolbar 
icon.  I can't easily find my way back to the Navigator view/file selection 
for the just touched file.

Package Explorer - not possible in 2.1.1 (had to refactor>rename), but most 
works in 3.0, better than Nav view.  The F2 is honored (at least for 
build.properties file), a rename/enter leaves focus on the file - but it is 
not selected.
Comment 1 Nick Edgar CLA 2004-06-04 11:33:33 EDT 
Should investigate for RC2.
Comment 2 Nick Edgar CLA 2004-06-10 00:42:30 EDT 
This was introduced by the change in bug 47176 comment #2.
Since the text widget is no longer disposed before the dialog is opened, it is
remembered as the "saved focus control" of the shell.  However, it is disposed
before focus is restored to the main window, so focus ends up on the first child
of the shell.

Rather than backing out of this change, which reduces flicker, it would be
better just to explicitly set focus on the Navigator's tree, either before the
dialog is opened, or after it is closed.
Comment 3 Nick Edgar CLA 2004-06-10 00:48:49 EDT 
Created attachment 11854 [details]
Patch to RenameResourceAction

Kim, could you please verify this patch?
Comment 4 Kim Horne CLA 2004-06-10 09:00:33 EDT 
The patch looks fine to me.
Comment 5 Nick Edgar CLA 2004-06-10 14:39:52 EDT 
Patch released.
Comment 6 Nick Edgar CLA 2004-06-11 10:10:15 EDT 
Verified in I20040611-0010