Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 60768

Summary:

CBanner at top does vertical sizing based on left components

Product:

[Eclipse Project] Platform

Reporter:

Douglas Pollock <douglas.pollock>

Component:

Assignee:

Hanna Farah <farahtech2002>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

sxenos

Version:

3.0

Keywords:

accessibility

Target Milestone:

3.1

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
Fix for CBanner	none
Fix for UI Workbench	none
Fix for UI Workbench	none

Description Douglas Pollock

2004-05-03 11:42:52 EDT

If the text on the buttons on the right is larger than the height of the image 
alone, then the buttons become cut off.  This can be easily seen by bumping up 
the font size on the OS.  It happens by default on my machine. 
 
This should be easy enough to fix, but has a fairly significant visual effect 
for Linux users.

Comment 1 Michael Van Meekeren

2004-05-12 13:48:27 EDT

stefan, here is another perspective bug

Comment 2 Michael Van Meekeren

2004-06-08 15:31:57 EDT

can you recreate this now Doug?

Comment 3 Michael Van Meekeren

2004-06-09 12:09:43 EDT

Actually if I use Extra Large fonts on WinXp I can recreate this there as 
well.  The height of the CBanner should be at least as high as one row of 
perspective icons OR main coolbar items which ever is higher.

Comment 4 Douglas Pollock

2004-06-10 10:26:21 EDT

I can still see this.

Comment 5 Michael Van Meekeren

2004-06-17 19:54:50 EDT

fixed in HEAD,  reviewed by DP, Hanna and mvm

Comment 6 Michael Van Meekeren

2004-06-18 20:00:20 EDT

reopening, this caused a regression in CBanner, this bug is not going in for RC3

Comment 7 Hanna Farah

2004-06-30 13:50:11 EDT

Created attachment 12920 [details]
Fix for CBanner

Comment 8 Hanna Farah

2004-06-30 13:50:33 EDT

Created attachment 12921 [details]
Fix for UI Workbench

Comment 9 Hanna Farah

2004-07-05 14:06:29 EDT

Created attachment 12968 [details]
Fix for UI Workbench

This is a better fix for UI Workbench, better performance and correct size of
CBanner on start up.

Comment 10 Veronika Irvine

2004-07-06 11:46:25 EDT

I have released new API on CBanner into HEAD.  See CBanner.setRightMinimumSize
(Point) and CBanner.getRightMinimumSize().

I have some suggestions for the patch to UI workbench:

1) You need to call PerspectiveSwitcher.updateCBannerHeight every time you add 
or remove a perspective from the toolbar - otherwise there is no point in 
iterating over the items in the toolbar to get the max height - you may as 
well just use the first one.

2) PerspectiveSwitcher.updateCBannerHeight should also update the minimum 
width for the right based on the widest item plus room for the chevron

3) In setCoolItemSize, it does not seem neccessary to iterate again over the 
toolitems and get the tallest item since that value should be correctly stored 
in CBanner.getRightMinimumSize().

4) I still don't see what the following code in setCoolItemSize is doing:

area.height = topBar.getLeft().getBounds().height;

I think it either has no effect or it is bad.

Comment 11 Michael Van Meekeren

2004-07-06 12:08:15 EDT

fixed in HEAD

Comment 12 Michael Van Meekeren

2005-05-31 16:22:13 EDT

verified on win2k build 3.1 RC1