Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 581508

Summary: FilterRowDataProvider should support ContextualDisplayConverter
Product: [Technology] NatTable Reporter: Dirk Fauth <dirk.fauth>
Component: CoreAssignee: Dirk Fauth <dirk.fauth>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3    
Version: 2.0.5   
Target Milestone: 2.1.0   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/c/nattable/org.eclipse.nebula.widgets.nattable/+/199823
https://git.eclipse.org/c/nattable/org.eclipse.nebula.widgets.nattable.git/commit/?id=37005e8dce525b69726bc6c7848d632581bdafbf
Whiteboard:

Description Dirk Fauth CLA 2023-02-09 03:07:58 EST 
The FilterRowDataProvider uses the configured IDisplayConverter for state persistence. On loadState() and saveState() it does not support the usage of a ContextualDisplayConverter, as there is no context in terms of an ILayerCell.

To add at least the support for a minimal context, we can call the contextual conversion by using a fake LayerCell that only contains the columnIndex and rowIndex.

This change should be safe with regards to existing filter states or non-contextual display converters.
Comment 1 Eclipse Genie CLA 2023-02-09 03:38:35 EST 
New Gerrit change created: https://git.eclipse.org/r/c/nattable/org.eclipse.nebula.widgets.nattable/+/199823
Comment 3 Dirk Fauth CLA 2023-03-31 03:46:45 EDT 
Fixed with 2.1.0