Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 581023

Summary:	Not possible to simply clear filter of "Excel-like" filters
Product:	[Technology] NatTable	Reporter:	Dirk Fauth <dirk.fauth>
Component:	GlazedLists Extension	Assignee:	Dirk Fauth <dirk.fauth>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	2.0.3
Target Milestone:	2.1.0
Hardware:	PC
OS:	Windows 10
See Also:	https://git.eclipse.org/r/c/nattable/org.eclipse.nebula.widgets.nattable/+/196859 https://git.eclipse.org/c/nattable/org.eclipse.nebula.widgets.nattable.git/commit/?id=40eb716758467093ca42409d2fbf5293c4747266 https://git.eclipse.org/r/c/nattable/org.eclipse.nebula.widgets.nattable/+/196874 https://git.eclipse.org/c/nattable/org.eclipse.nebula.widgets.nattable.git/commit/?id=2c568e2f9cb0ad50bcc58a2b18de8e8dbc2c4f3d
Whiteboard:

Description Dirk Fauth

2022-11-10 03:56:59 EST

The filter row in NatTable shows an icon to the right if a filter is applied. The default filter editors/painters support to clean the filter of that column on clicking that filter icon.

Cleaning the filter of a "Excel-like" filter editor / painter does not work. A click on the item is opening the drop down. While it is sufficient for a user to clear the filter this way by clicking "Select All" in the opened dropdown, it is not consistent.

By looking into the configuration the UI binding to match the filter icon of the filter row painter of the ComboBoxFilterRowConfiguration is missing. Adding that configuration makes the clean action work.

Comment 1 Eclipse Genie

2022-11-10 04:00:49 EST

New Gerrit change created: https://git.eclipse.org/r/c/nattable/org.eclipse.nebula.widgets.nattable/+/196859

Comment 2 Eclipse Genie

2022-11-10 05:26:55 EST

Gerrit change https://git.eclipse.org/r/c/nattable/org.eclipse.nebula.widgets.nattable/+/196859 was merged to [master].
Commit: http://git.eclipse.org/c/nattable/org.eclipse.nebula.widgets.nattable.git/commit/?id=40eb716758467093ca42409d2fbf5293c4747266

Comment 3 Eclipse Genie

2022-11-11 03:07:40 EST

New Gerrit change created: https://git.eclipse.org/r/c/nattable/org.eclipse.nebula.widgets.nattable/+/196874

Comment 4 Eclipse Genie

2022-11-11 03:26:05 EST

Gerrit change https://git.eclipse.org/r/c/nattable/org.eclipse.nebula.widgets.nattable/+/196874 was merged to [master].
Commit: http://git.eclipse.org/c/nattable/org.eclipse.nebula.widgets.nattable.git/commit/?id=2c568e2f9cb0ad50bcc58a2b18de8e8dbc2c4f3d

Comment 5 Dirk Fauth

2022-11-11 03:30:42 EST

The applied fix is only working partially. While it is possible to clear the filter now, a click on the combobox icon if no filter is applied does not open the combobox anymore. While this is a minor issue, it is not consistent. The reason is that the check if a filter is applied or not in the matcher needs another information than the default matcher, because a not-applied-filter means everything is selected, and that is not null.

To fix this a reference to the IComboBoxDataProvider is needed, similar to the ComboBoxFilterIconPainter. As this means introducing a new constructor and new fields, the complete fix of this ticket needs to be postponed to a 2.1

Comment 6 Dirk Fauth

2023-03-31 03:50:49 EDT

Fixed with 2.1.0