Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 578364

Summary: Alt+Shift+R conflicts at project, after long time flashing show conflicts
Product: [Eclipse Project] JDT Reporter: yong ma <569098082>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: CLOSED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: Ed.Merks, jonah, kalyan_prasad, mistria
Version: 4.22   
Target Milestone: ---   
Hardware: PC   
OS: Windows 10   
Whiteboard:
Attachments:
Description Flags
key binds
none
after flashing show windows on right down
none
flashing windows title color to be gray
none
normal window title color is black
none
alt shift r at explorer file node
none
open rename windows
none
always together bind or unbind rows
none
Alt+Shift+R bound command
none
All rename related commands
none
same command none

Description yong ma CLA 2022-01-25 01:54:52 EST
Created attachment 287889 [details]
key binds

in project explorer, select project and press Alt+Shift+R, screen flashing busy, not respond any input.
when I unbind Alt+Shift+R is ok, bug Alt+Shift+R not work in class file.
Comment 1 yong ma CLA 2022-01-25 01:56:37 EST
Created attachment 287890 [details]
after flashing show windows on right down
Comment 2 yong ma CLA 2022-01-25 01:57:50 EST
Created attachment 287891 [details]
flashing windows title color to be gray
Comment 3 yong ma CLA 2022-01-25 01:58:23 EST
Created attachment 287892 [details]
normal window  title color is black
Comment 4 yong ma CLA 2022-01-25 02:09:54 EST
Alt+Shift+R on file in explorer is rename, now Alt+Shfit+R bind to Rename-Refactoring and Rename together, I can't unbind any one single, bind together and unbind together too.
Comment 5 Kalyan Prasad Tatavarthi CLA 2022-01-25 02:45:56 EST
(In reply to yong ma from comment #0)
> Created attachment 287889 [details]
> key binds
> 
> in project explorer, select project and press Alt+Shift+R, screen flashing
> busy, not respond any input.
> when I unbind Alt+Shift+R is ok, bug Alt+Shift+R not work in class file.

The attachment clearly shows that there is a conflict for Alt+Shift+R .

There is a Rename command, as well as 
Rename - Refactoring command provided by JDT UI.

How did you create the first Rename command which binds to Alt+Shift+R.

Please remove this command. I do not see the rename command associated to Alt+Shift+R in Eclipse install. It is associated with F2 only.

In the attachment 287889 [details], we clearly see two instances of Rename, one associated with F2 and one with Alt+Shift+R.
Comment 6 yong ma CLA 2022-01-25 03:19:11 EST
Alt+Shift+R bind is original state, not customer bind. F2 rename file is normal,  Alt+Shfit+R on file in explorer is Rename Compilation Unit at Eclipse version 4.18. 
4.19-4.21 has a bug about content assist, so I back to 4.18. now 4.22 fix this bug about content assist, I want switch to 4.22, bug find a new bug 
 Alt+Shfit+R conflict.
in 4.18 Alt+Shift+R can rename file in explorer and rename class name on java file  editor. but 4.22 only rename class name on java file. 

in keys table, has 2 rows alt + shift + R  has  'C'  at  user column , they unbind or bind always together, i try unbind any one other one sync unbind .
i think these two rows has problem, 4.18 version unbind single is ok.
Comment 7 yong ma CLA 2022-01-25 03:19:54 EST
Created attachment 287893 [details]
alt shift r at explorer file node
Comment 8 yong ma CLA 2022-01-25 03:20:27 EST
Created attachment 287894 [details]
open rename windows
Comment 9 yong ma CLA 2022-01-25 03:21:06 EST
Created attachment 287895 [details]
always together bind or unbind rows
Comment 10 Kalyan Prasad Tatavarthi CLA 2022-01-25 04:14:34 EST
Created attachment 287896 [details]
Alt+Shift+R bound command

Attachment showing all commands which are bound to Alt+Shift+R. Rename is not present here. This is in 4.18
Comment 11 Kalyan Prasad Tatavarthi CLA 2022-01-25 04:21:42 EST
Created attachment 287897 [details]
All rename related commands

This attachment shows all searches for Rename in commands.

Even here there is no 'Rename' command linked to Alt+Shift+R 
and no conflict. This is also in 4.18
Comment 12 yong ma CLA 2022-01-25 04:35:18 EST
I don't know why, I confirm this bind command 
with my friends, bind is default real. I think this two rows bind together sync, unbind these any one other alse to be unbind, restore bind these all restore to Alt+Shfit+R.
I try unbind and bind Rename to F2, then bind refactor to Alt+Shfit+R manual.
now this is ok. like you post bind command image. bug these row has 'U' flag at column user in command table. 
The real magic is that Alt+Shfit+R at file in explorer can open rename resource windows. 
Could that be the reason my eclipse is eclipse-jee version?
Comment 13 yong ma CLA 2022-01-25 05:47:56 EST
keys command table has two same command.
Rename In Windows - File
Comment 14 yong ma CLA 2022-01-25 05:48:17 EST
Created attachment 287899 [details]
same command
Comment 15 Ed Merks CLA 2022-01-25 07:39:50 EST
Isn't this the same issue as 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=578135


Which got moved to there:

https://github.com/eclipse/lsp4e/issues/38

Or is this related?

https://github.com/eclipse-m2e/m2e-core/issues/415
Comment 16 Kalyan Prasad Tatavarthi CLA 2022-01-25 08:04:36 EST
(In reply to Ed Merks from comment #15)
> Isn't this the same issue as 
> 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=578135
> 
> 
> Which got moved to there:
> 
> https://github.com/eclipse/lsp4e/issues/38
> 
> Or is this related?
> 
> https://github.com/eclipse-m2e/m2e-core/issues/415

yes , this is the same issue. Marking this as duplicate of 578135

*** This bug has been marked as a duplicate of bug 578135 ***
Comment 17 Kalyan Prasad Tatavarthi CLA 2022-01-25 08:13:34 EST
(In reply to Kalyan Prasad Tatavarthi from comment #16)
> (In reply to Ed Merks from comment #15)
> > Isn't this the same issue as 
> > 
> > https://bugs.eclipse.org/bugs/show_bug.cgi?id=578135
> > 
> > 
> > Which got moved to there:
> > 
> > https://github.com/eclipse/lsp4e/issues/38
> > 
> > Or is this related?
> > 
> > https://github.com/eclipse-m2e/m2e-core/issues/415
> 
> yes , this is the same issue. Marking this as duplicate of 578135
> 
> *** This bug has been marked as a duplicate of bug 578135 ***

The conflict of Alt+Shift+R is occurring due to the fix for bug 525413. The github issue tracking this conflict problem is https://github.com/eclipse/lsp4e/issues/38.

As a workaround, till this issue is fixed, you can change the key binding for "Rename" from "Alt+Shift+R" something else , which will resolve the conflict.