Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 577743

Summary: [launch view] Missing mnemonics in the launch configurations view context menu
Product: [Eclipse Project] Platform Reporter: Wolfgang Schramm <wolfgang.schramm>
Component: DebugAssignee: Wolfgang Schramm <wolfgang.schramm>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Lars.Vogel, sarika.sinha
Version: 4.22   
Target Milestone: 4.23 M2   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189859
https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=92cdc99068cb9c3aca5ca1ea7818caa8b7849c42
Whiteboard:
Bug Depends on:    
Bug Blocks: 513735    
Attachments:
Description Flags
Launch configurations context menu none

Description Wolfgang Schramm CLA 2021-12-10 08:23:41 EST
Created attachment 287659 [details]
Launch configurations context menu

Some actions in the context menu (you can open it with <Shift>+F10) of the launch configurations view has no mnemonics, e.g. you cannot access the "Edit" action with just one key, like "e", you have to navigate with the cursor keys to access this action.

I also discovered that the lower actions "Remove", "Team", ... are sometimes displayed and sometimes not.
Comment 1 Lars Vogel CLA 2021-12-10 08:45:05 EST
Wolfgang, can you push a Gerrit to add the mnemonics?
Comment 2 Wolfgang Schramm CLA 2021-12-11 01:19:10 EST
I'm using Eclipse since 2005 mainly for a RCP app but have zero experience with Eclipse internals and Gerrit.
Comment 3 Lars Vogel CLA 2021-12-13 08:39:26 EST
(In reply to Wolfgang Schramm from comment #2)
> I'm using Eclipse since 2005 mainly for a RCP app but have zero experience
> with Eclipse internals and Gerrit.

Gerrit setup should be relatively fast, see https://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html#exercise-setup-user-account and to define the mnemonics you only need to add & in front of the text in property files.
Comment 4 Wolfgang Schramm CLA 2021-12-26 03:36:26 EST
To setup Gerrit with your documentation was almost smoothly but when I cloned "platform/eclipse.platform.ui" I got this error:

!ENTRY org.eclipse.egit.ui 4 0 2021-12-23 16:43:05.587
!MESSAGE Git repository clone failed.
!STACK 0
org.eclipse.jgit.api.errors.TransportException: Read timed out after 30,000 ms
	at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:224)
	at org.eclipse.jgit.api.CloneCommand.fetch(CloneCommand.java:311)
	at org.eclipse.jgit.api.CloneCommand.call(CloneCommand.java:182)
	at org.eclipse.egit.core.op.CloneOperation.run(CloneOperation.java:194)
	at org.eclipse.egit.ui.internal.clone.AbstractGitCloneWizard.executeCloneOperation(AbstractGitCloneWizard.java:490)
	at org.eclipse.egit.ui.internal.clone.AbstractGitCloneWizard$5.run(AbstractGitCloneWizard.java:446)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122)
Caused by: org.eclipse.jgit.errors.TransportException: Read timed out after 30,000 ms
	at org.eclipse.jgit.transport.BasePackConnection.lsRefs(BasePackConnection.java:308)
	at org.eclipse.jgit.transport.TransportGitSsh$SshFetchConnection.<init>(TransportGitSsh.java:319)
	at org.eclipse.jgit.transport.TransportGitSsh.openFetch(TransportGitSsh.java:153)
	at org.eclipse.jgit.transport.FetchProcess.reopenConnection(FetchProcess.java:305)
	at org.eclipse.jgit.transport.FetchProcess.executeImp(FetchProcess.java:196)
	at org.eclipse.jgit.transport.FetchProcess.execute(FetchProcess.java:93)
	at org.eclipse.jgit.transport.Transport.fetch(Transport.java:1309)
	at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:213)
	... 6 more
Caused by: java.io.InterruptedIOException: Read timed out after 30,000 ms
	at org.eclipse.jgit.util.io.TimeoutInputStream.readTimedOut(TimeoutInputStream.java:120)
	at org.eclipse.jgit.util.io.TimeoutInputStream.read(TimeoutInputStream.java:92)
	at org.eclipse.jgit.util.IO.readFully(IO.java:201)
	at org.eclipse.jgit.transport.PacketLineIn.readLength(PacketLineIn.java:316)
	at org.eclipse.jgit.transport.PacketLineIn.readString(PacketLineIn.java:180)
	at org.eclipse.jgit.transport.BasePackConnection.readLine(BasePackConnection.java:190)
	at org.eclipse.jgit.transport.BasePackConnection.lsRefsImpl(BasePackConnection.java:330)
	at org.eclipse.jgit.transport.BasePackConnection.lsRefs(BasePackConnection.java:302)
	... 13 more
Caused by: java.io.InterruptedIOException: Interrupted at cycle #0 while waiting for data to become available
	at org.apache.sshd.common.channel.ChannelPipedInputStream.read(ChannelPipedInputStream.java:147)
	at java.base/java.io.FilterInputStream.read(FilterInputStream.java:133)
	at org.eclipse.jgit.util.io.TimeoutInputStream.read(TimeoutInputStream.java:90)
	... 19 more
Caused by: java.lang.InterruptedException
	at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.reportInterruptAfterWait(AbstractQueuedSynchronizer.java:2056)
	at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2090)
	at org.apache.sshd.common.channel.ChannelPipedInputStream.read(ChannelPipedInputStream.java:144)
	... 21 more

I tried it several times but got always the same error, with help from https://stackoverflow.com/questions/31386645/pushing-from-eclipse-to-openshift-read-timeout-after-30-000-ms#answer-31432388 I increased the timeout to 120 seconds and the git repo could be cloned successfully, a smaller value may also work but was not tested.

You may update your helpful documentation to point out the problem.
Comment 5 Eclipse Genie CLA 2022-01-21 01:41:00 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/189859
Comment 7 Sarika Sinha CLA 2022-01-21 13:57:46 EST
Thanks Wolfgang Schramm !
Comment 8 Sarika Sinha CLA 2022-02-15 00:05:02 EST
I20220214-1800