Bugzilla – Full Text Bug Listing
| Summary: | Company affiliation missing | ||
|---|---|---|---|
| Product: | Community | Reporter: | Ivar Grimstad <ivar.grimstad> |
| Component: | Project Management & Portal | Assignee: | Eclipse Web <webdev> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | chris.guindon, wayne.beaton, webmaster |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
|
Description
Ivar Grimstad
Re-asigning to the portal component. I took a really quick look at the committer db and things look ok to me. @webdev any ideas? -M. I can see that Tomas Langer is correctly affiliated with Oracle. However, I see the problem. A Gmail email address was used to make the commit, not the Oracle email address that we have on file. https://api.github.com/repos/eclipse-ee4j/config/commits/03b8d472c59aa8821e32f3d0da3956c1232107c0 The data that we use to generate the charts depends on the email address on the commit being the same as the email address on the EF account. @webdev, my understanding is that our hooks require (and enforce) that the commit author's email address matches the email address on the corresponding EF account. Is is this understanding correct? Closing this issue since this is working as expected. I can see that Tomas is using his Oracle address for commits on an open PR: https://api.github.com/repos/eclipse-ee4j/config/commits/1d510071806f231fbbeb7b14c101a8f73ea5bec6 I would expect those to be attributed as expected. Good to know. I'll give that feedback to Tomas. Shouldn't it be possible to use the github username to make the connection? (In reply to Wayne Beaton from comment #3) > @webdev, my understanding is that our hooks require (and enforce) that the > commit author's email address matches the email address on the corresponding > EF account. Is is this understanding correct? A PR is required to trigger our ECA validation tool. That initial commit was pushed directly to the repo since I don't see any closed PR for the project: https://github.com/eclipse-ee4j/config/pull/6 Enforce is not correct with Github. The ECA informs the committers and contributions of the current ECA state of the author(s). (In reply to Ivar Grimstad from comment #5) > Good to know. I'll give that feedback to Tomas. > > Shouldn't it be possible to use the github username to make the connection? Everything is possible without enough time :) For example, we could query Github API to fetch additional information about the commit such as the Github Username, and store that in one of our databases. However, the current tool makes connections based on the information stored in the git repository. (In reply to Christopher Guindon from comment #7) > (In reply to Ivar Grimstad from comment #5) > > Good to know. I'll give that feedback to Tomas. > > > > Shouldn't it be possible to use the github username to make the connection? > > Everything is possible without enough time :) *with However, We plan on fixing this by allowing users to associate more than 1 email address to their account. In this situation, the fix would be easy. We would ask Tomas to add his gmail address to his account. I expect us to look at implementing this in 2022. |